pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: David Steele <david@pgmasters.net>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: remove more archiving overhead
Date: Thu, 7 Jul 2022 17:06:13 -0400
Message-ID: <ba7e11b0-054d-1d26-bafd-7a2bc97f11f7@pgmasters.net> (raw)
In-Reply-To: <20220707182251.GA2255242@nathanxps13>
References: <20220222173711.GA3852671@nathanxps13>
	<20220222195229.GA42988@nathanxps13>
	<20220224.141349.1809640551882183816.horikyota.ntt@gmail.com>
	<20220224175553.GA660690@nathanxps13>
	<20220407222327.GA1363808@nathanxps13>
	<768e6cb3-256d-9c0b-1797-62420ffca7ae@oss.nttdata.com>
	<CA+TgmoaeTe4oUT39A4nt=8LD6UJ5u0vcmGc5+Aksn-4oKRb8-w@mail.gmail.com>
	<17147b74-5465-9a7a-ae27-305d1200482c@pgmasters.net>
	<20220707161825.GA2205004@nathanxps13>
	<20220707175142.GA2254092@nathanxps13>
	<20220707182251.GA2255242@nathanxps13>

On 7/7/22 14:22, Nathan Bossart wrote:
> On Thu, Jul 07, 2022 at 10:51:42AM -0700, Nathan Bossart wrote:
>> +    library to ensure that it indeed does not overwrite an existing file.  When
>> +    a pre-existing file is encountered, the archive library may return
>> +    <literal>true</literal> if the WAL file has identical contents to the
>> +    pre-existing archive.  Alternatively, the archive library can return
> 
> This should likely say something about ensuring the pre-existing file is
> persisted to disk before returning true.

Agreed.

Also, I'd prefer to remove "indeed" from this sentence (yes, I see that 
was in the original text):

+    library to ensure that it indeed does not overwrite an existing

Regards,
-David





view thread (40+ messages)  latest in thread

Message-ID: <ba7e11b0-054d-1d26-bafd-7a2bc97f11f7@pgmasters.net>
Permalink:  ../ba7e11b0-054d-1d26-bafd-7a2bc97f11f7@pgmasters.net/
Also on:    postgresql.org/message-id/ba7e11b0-054d-1d26-bafd-7a2bc97f11f7@pgmasters.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@pgmasters.net, nathandbossart@gmail.com, robertmhaas@gmail.com, masao.fujii@oss.nttdata.com, horikyota.ntt@gmail.com
  Subject: Re: remove more archiving overhead
  In-Reply-To: <ba7e11b0-054d-1d26-bafd-7a2bc97f11f7@pgmasters.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox