From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: samay sharma <smilingsamay@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: Inconsistencies around defining FRONTEND
Date: Tue, 23 Aug 2022 16:24:45 -0700
Message-ID: <20220823232445.jpp56meso7fgrpns@awork3.anarazel.de> (raw)
In-Reply-To: <CA+TgmoZZ3n5-RB83e8oC7BJW9DuGSCXe+1cB0ApqNV80FZqkbw@mail.gmail.com>
References: <20220820194550.725755r6fj2ro3rx@awork3.anarazel.de>
<CA+TgmoZZ3n5-RB83e8oC7BJW9DuGSCXe+1cB0ApqNV80FZqkbw@mail.gmail.com>
Hi,
On 2022-08-23 17:24:30 -0400, Robert Haas wrote:
> On Sat, Aug 20, 2022 at 3:46 PM Andres Freund <andres@anarazel.de> wrote:
> > Unfortunately, the remaining uses of FRONTEND are required. That's:
> > - pg_controldata, via #define
> > - pg_resetwal, via #define
> > - pg_rewind, via -DFRONTEND, due to xlogreader.c
> > - pg_waldump, via #define and -DFRONTEND, due to xlogreader.c, xlogstats.c, rmgrdesc/*desc.c
>
> Actually, I think we could fix these pretty easily too.
I just meant that they're not already obsolete ;)
> See attached.
Just to make sure I understand - you're just trying to get rid of the #define
frontends, not the -DFRONTENDs passed in from the Makefile? Because afaics we
still need those, correct?
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andres@anarazel.de, robertmhaas@gmail.com, peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us, noah@leadboat.com, smilingsamay@gmail.com, byavuz81@gmail.com
Subject: Re: Inconsistencies around defining FRONTEND
In-Reply-To: <20220823232445.jpp56meso7fgrpns@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox