From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: samay sharma <smilingsamay@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: [RFC] building postgres with meson - v12
Date: Sun, 28 Aug 2022 12:08:07 -0500
Message-ID: <20220828170806.GN2342@telsasoft.com> (raw)
In-Reply-To: <20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
<20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de>
with_temp_install is repeated twice in prove_check:
> Subject: [PATCH v12 02/15] Split TESTDIR into TESTLOGDIR and TESTDATADIR
>
> - TESTDIR='$(CURDIR)/tmp_check' $(with_temp_install)
> PGPORT='6$(DEF_PGPORT)' \
> + TESTLOGDIR='$(CURDIR)/tmp_check/log' $(with_temp_install) \
> + TESTDATADIR='$(CURDIR)/tmp_check' $(with_temp_install) \
> + PGPORT='6$(DEF_PGPORT)' \
Before running an individual test like "meson test recovery/017_shm",
it's currently necessary to first manually run "meson test tmp_install".
Is it possible to make that happen automatically ?
You're running tap tests via a python script. There's no problem with
that, but it's different from what's done by the existing makefiles.
I was able to remove the python indirection - maybe that's better to
talk about on the CI thread? That moves some setup for TAP tests
(TESTDIR, PATH, cd) from Makefile into the existing perl, which means
less duplication.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, andres@anarazel.de, peter.eisentraut@enterprisedb.com, smilingsamay@gmail.com, byavuz81@gmail.com
Subject: Re: [RFC] building postgres with meson - v12
In-Reply-To: <20220828170806.GN2342@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox