From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [BUG] wrong FK constraint name when colliding name on ATTACH
Date: Thu, 8 Sep 2022 14:07:16 +0200
Message-ID: <20220908140716.0323dedd@karst> (raw)
In-Reply-To: <20220908112515.5pe5obtk4a63aiee@alvherre.pgsql>
References: <20220908094026.640a0224@karst>
<20220908112515.5pe5obtk4a63aiee@alvherre.pgsql>
On Thu, 8 Sep 2022 13:25:15 +0200
Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> On 2022-Sep-08, Jehan-Guillaume de Rorthais wrote:
>
> > Hi there,
> >
> > I believe this very small bug and its fix are really trivial and could be
> > push out of the way quite quickly. It's just about a bad constraint name
> > fixed by moving one assignation after the next one. This could easily be
> > fixed for next round of releases.
> >
> > Well, I hope I'm not wrong :)
>
> I think you're right, so pushed, and backpatched to 12. I added the
> test case to regression also.
Great, thank you for the additional work on the regression test and the commit!
> For 11, I adjusted the test case so that it didn't depend on an FK
> pointing to a partitioned table (which is not supported there); it turns
> out that the old code is not smart enough to get into the problem in the
> first place. [...]
> It seems fair to say that this case, with pg11, is unsupported and
> people should upgrade if they want better behavior.
That works for me.
Thanks!
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jgdr@dalibo.com, alvherre@alvh.no-ip.org
Subject: Re: [BUG] wrong FK constraint name when colliding name on ATTACH
In-Reply-To: <20220908140716.0323dedd@karst>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox