From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Date: Tue, 20 Sep 2022 16:50:10 -0700
Message-ID: <20220920235010.GB378596@nathanxps13> (raw)
In-Reply-To: <20220920233117.GA378596@nathanxps13>
References: <CA+Tgmobi96u71+ChcrtGoymwp=9YzMGCu_vhnDp_avawV96Uyw@mail.gmail.com>
<20220906155432.GA1963795@nathanxps13>
<20220907211343.GE26002@tamriel.snowman.net>
<20220907221103.GA2095022@nathanxps13>
<CAOuzzgr60X+pnVphekO=WnAwGo9pTbo9ZG_GK4nFaR=Dxqd1hg@mail.gmail.com>
<CA+TgmoaQExEDdRmQsFCd955dxCypDBeA_FOrUKCLNWAdQ69zxg@mail.gmail.com>
<20220920035147.GA114383@nathanxps13>
<YylTkIwvWuYJkMnT@paquier.xyz>
<20220920180533.GA205278@nathanxps13>
<20220920233117.GA378596@nathanxps13>
On Tue, Sep 20, 2022 at 04:31:17PM -0700, Nathan Bossart wrote:
> On Tue, Sep 20, 2022 at 11:05:33AM -0700, Nathan Bossart wrote:
>> On Tue, Sep 20, 2022 at 02:45:52PM +0900, Michael Paquier wrote:
>>> Any impact for the column sizes of the catalogs holding ACL
>>> information? Just asking while browsing the patch set.
>>
>> Since each aclitem requires 16 bytes instead of 12, I assume so. However,
>> in my testing, I hit a "row is too big" error with the same number of
>> aclitems in a pg_class row before and after the change. I might be missing
>> something in my patch, or maybe I am misunderstanding how arrays of
>> aclitems are stored on disk.
>
> Ah, it looks like relacl is compressed. The column is marked "extended,"
> but pg_class doesn't appear to have a TOAST table, so presumably no
> out-of-line storage can be used. I found a couple of threads about this
> [0] [1] [2].
I suppose there is some risk that folks with really long aclitem arrays
might be unable to pg_upgrade to a version with uint64 AclModes, but I
suspect that risk is limited to extreme cases (i.e., multiple thousands of
aclitems). I'm not sure whether that's worth worrying about too much.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, michael@paquier.xyz, robertmhaas@gmail.com, sfrost@snowman.net, bharath.rupireddyforpostgres@gmail.com, david.g.johnston@gmail.com, horikyota.ntt@gmail.com
Subject: Re: predefined role(s) for VACUUM and ANALYZE
In-Reply-To: <20220920235010.GB378596@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox