From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: wangw.fnst@fujitsu.com, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: samay sharma <smilingsamay@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [RFC] building postgres with meson - v13
Date: Sun, 2 Oct 2022 19:19:35 -0500
Message-ID: <20221003001935.GF7745@telsasoft.com> (raw)
In-Reply-To: <20221002183837.GD7745@telsasoft.com>
References: <20220922223729.GA721620@nathanxps13>
<2298281.1664041949@sss.pgh.pa.us>
<20220924180955.2hevwoniwsj2q2tm@awork3.anarazel.de>
<c5736f70-bb6d-8d25-e35c-e3d886e4e905@enterprisedb.com>
<20220926163516.ftxjmoljjwyy4m2q@awork3.anarazel.de>
<20220926194435.4hhrwu7d6anrapc3@awork3.anarazel.de>
<20220927011951.j3h4o7n6bhf7dwau@awork3.anarazel.de>
<20221002172520.GC7745@telsasoft.com>
<20221002180530.fkhl6kpx734dlmow@awork3.anarazel.de>
<20221002183837.GD7745@telsasoft.com>
On Sun, Oct 02, 2022 at 01:38:37PM -0500, Justin Pryzby wrote:
> On Sun, Oct 02, 2022 at 11:05:30AM -0700, Andres Freund wrote:
> > > Also, you wrote "rm -fr build" between building for gcc and clang, but
> > > since they run in an "always" block, it'd be better to use separate
> > > dirs, to allow seeing logs for the the all (failed) tasks, in case the
> > > last one succeeds.
> >
> > Hm, when are logs important for CompilerWarnings? I don't think we even
> > collect any? Using a different builddir for the "sibling" tests (i.e. the two
> > gcc and the two clang tests) would increase the times a bit because we'd
> > regenerate the bison files etc.
> >
> > I guess it'll look a bit cleaner to use a build-gcc and a build-clang, just to
> > get rid of the irregularity of needing that rm -rf.
>
> The build logs are important when hacking on .cirrus.yml itself.
>
> You're right that we don't normally save logs for CompilerWarnings; one or
> another (unpublished) patch of mine adds that, and then also needed to change
> to use separate dirs in order to debug building while experimenting with your
> patch to use meson.
FYI, this is what led me to make that suggestion.
https://cirrus-ci.com/task/5920691940753408
I had a patch laying around to change the "compiler warnings" task to
use debian "testing", which seems to have added some new flags in -Wall,
which caused me to add (for now) some compiler flags like -Wno-error=...
But when I added them to the task's CFLAGS, it broke "clang" (which
doesn't support the warnings) in an obscure way[0], and no logs
available to show why.
[0] Header "uuid/uuid.h" has symbol "uuid_generate" with dependency
uuid: NO
So, I think it's worth reporting meson's build logs, even though no
tests are run here.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, andres@anarazel.de, peter.eisentraut@enterprisedb.com, pg@bowt.ie, tgl@sss.pgh.pa.us, nathandbossart@gmail.com, andrew@dunslane.net, thomas.munro@gmail.com, smilingsamay@gmail.com, byavuz81@gmail.com
Subject: Re: [RFC] building postgres with meson - v13
In-Reply-To: <20221003001935.GF7745@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox