From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: bharath.rupireddyforpostgres@gmail.com
Cc: tgl@sss.pgh.pa.us
Cc: peter.eisentraut@enterprisedb.com
Cc: benoit.lobreau@gmail.com
Cc: alvherre@alvh.no-ip.org
Cc: robertmhaas@gmail.com
Cc: bossartn@amazon.com
Cc: david@pgmasters.net
Cc: masao.fujii@oss.nttdata.com
Cc: pgsql-hackers@postgresql.org
Cc: magnus@hagander.net
Cc: sfrost@snowman.net
Subject: Re: archive modules
Date: Mon, 7 Nov 2022 13:15:47 -0800
Message-ID: <20221107211547.GA632101@nathanxps13> (raw)
In-Reply-To: <Y2ijr24u+BxyeRxA@paquier.xyz>
References: <CALj2ACXYQckdBWQTpJDCRd9r7xxJsdnbuHp-DnNEAWpiPZwtfA@mail.gmail.com>
<20221014185130.GC1678424@nathanxps13>
<20221014214256.GA1819154@nathanxps13>
<20221017.134639.1811443236787336786.horikyota.ntt@gmail.com>
<Y0zs/wst7XY8rFbW@paquier.xyz>
<20221105210858.GB137360@nathanxps13>
<Y2ijr24u+BxyeRxA@paquier.xyz>
On Mon, Nov 07, 2022 at 03:20:31PM +0900, Michael Paquier wrote:
> On Sat, Nov 05, 2022 at 02:08:58PM -0700, Nathan Bossart wrote:
>> Perhaps we could eventually move the archive_command functionality to a
>> contrib module (i.e., "shell_archive") so that users must always set
>> archive_library. But until then, I suspect it's better to treat modules
>> and commands as two separate interfaces to ease migration from older major
>> versions (even though archive_command is now essentially a built-in archive
>> module).
>
> I agree that this is a fine long-term goal, removing all traces of the
> archive_command from the backend core code. This is actually an
> argument in favor of having no traces of XLogArchiveCommand in
> pgarch.c, no? ;p
Indeed.
> I am not sure how long we should wait before being able to do that,
> perhaps a couple of years of least? I'd like to think the sooner the
> better (like v17?) but we are usually conservative, and the removal of
> the exclusive backup mode took 5~6 years if I recall correctly..
Yeah, I imagine we'd need to mark it as deprecated-and-to-be-removed for
several years first.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, michael@paquier.xyz, horikyota.ntt@gmail.com, bharath.rupireddyforpostgres@gmail.com, tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, benoit.lobreau@gmail.com, alvherre@alvh.no-ip.org, robertmhaas@gmail.com, bossartn@amazon.com, david@pgmasters.net, masao.fujii@oss.nttdata.com, magnus@hagander.net, sfrost@snowman.net
Subject: Re: archive modules
In-Reply-To: <20221107211547.GA632101@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox