From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: samay sharma <smilingsamay@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: [RFC] building postgres with meson - v12
Date: Mon, 14 Nov 2022 17:16:46 -0600
Message-ID: <20221114231646.GM26337@telsasoft.com> (raw)
In-Reply-To: <20220828203741.mvseeiw2e56fpmni@awork3.anarazel.de>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
<20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de>
<20220828170806.GN2342@telsasoft.com>
<20220828203741.mvseeiw2e56fpmni@awork3.anarazel.de>
On Sun, Aug 28, 2022 at 01:37:41PM -0700, Andres Freund wrote:
> > You're running tap tests via a python script. There's no problem with
> > that, but it's different from what's done by the existing makefiles.
> > I was able to remove the python indirection - maybe that's better to
> > talk about on the CI thread? That moves some setup for TAP tests
> > (TESTDIR, PATH, cd) from Makefile into the existing perl, which means
> > less duplication.
>
> I'm doubtful it's worth removing. You'd need to move removing the files from
> the last run into both pg_regress and the tap test infrastructure. And I do
> think it's nice to afterwards have markers which tests failed, so we can only
> collect their logs.
Are you planning on putting something in place to remove (or allow
removing) logs for successful tests ? Is that primarily for cirrus, or
buildfarm or ??
It is wasteful to upload thousdands of logfiles to show a single
failure. That would make our cirrus tasks faster - compressing and
uploading the logs takes over a minute.
It's also a lot friendlier to show fewer than 8 pages of test folders to
search through to find the one that failed.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, andres@anarazel.de, peter.eisentraut@enterprisedb.com, smilingsamay@gmail.com, byavuz81@gmail.com
Subject: Re: [RFC] building postgres with meson - v12
In-Reply-To: <20221114231646.GM26337@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox