From: Nathan Bossart <nathandbossart@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
Date: Mon, 21 Nov 2022 18:50:33 -0800
Message-ID: <20221122025033.GA135551@nathanxps13> (raw)
In-Reply-To: <CA+hUKGJe50UztHqCrXsXMK_VkDvXNnxWfRo28XGN8YbWCeT-Zg@mail.gmail.com>
References: <20221122004119.GA132961@nathanxps13>
<CA+hUKGJe50UztHqCrXsXMK_VkDvXNnxWfRo28XGN8YbWCeT-Zg@mail.gmail.com>
On Tue, Nov 22, 2022 at 03:16:05PM +1300, Thomas Munro wrote:
> Maybe a comment to explain why a single variable is enough?
This crossed my mind shortly after sending my previous message. Looking
closer, I see that several types of ALTER SUBSCRIPTION do not call
PreventInTransactionBlock(), so a single variable might not be enough.
Perhaps we can put a list in TopTransactionContext. I'll do some more
investigation and report back.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, thomas.munro@gmail.com
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
In-Reply-To: <20221122025033.GA135551@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox