pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Xing Guo <higuoxing@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: PL/Python: Fix return in the middle of PG_TRY() block.
Date: Fri, 20 Jan 2023 11:02:01 -0800
Message-ID: <20230120190201.GC4106863@nathanxps13> (raw)
In-Reply-To: <20230120010711.jpqbaelpgmuvt2vq@awork3.anarazel.de>
References: <CACpMh+CMsGMRKFzFMm3bYTzQmMU5nfEEoEDU2apJcc4hid36AQ@mail.gmail.com>
	<20230112184433.GA2104952@nathanxps13>
	<20230113054900.b7onkvwtkrykeu3z@awork3.anarazel.de>
	<20230113180335.GA2160040@nathanxps13>
	<CACpMh+D9jz4Lq3qieoU2NkhGASqekhDXnXX2USW4mHa+SWNQag@mail.gmail.com>
	<1864041.1673882943@sss.pgh.pa.us>
	<20230120010711.jpqbaelpgmuvt2vq@awork3.anarazel.de>

On Thu, Jan 19, 2023 at 05:07:11PM -0800, Andres Freund wrote:
> I'm somewhat dubious about allowing to return inside PG_CATCH, even if it's
> safe today.

+1.  Unless there are known use-cases, IMHO it'd be better to restrict it
to prevent future compatibility breaks as PG_TRY evolves.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (20+ messages)  latest in thread

Message-ID: <20230120190201.GC4106863@nathanxps13>
Permalink:  ../20230120190201.GC4106863@nathanxps13/
Also on:    postgresql.org/message-id/20230120190201.GC4106863@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, higuoxing@gmail.com
  Subject: Re: PL/Python: Fix return in the middle of PG_TRY() block.
  In-Reply-To: <20230120190201.GC4106863@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox