public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value
Date: Tue, 24 Jan 2023 09:47:47 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAKrAKeWNYVS8aatr94ohKKwA10-dWsBbK=qYZKZnFhRxpWfi7A@mail.gmail.com>
	<[email protected]>

At Thu, 19 Jan 2023 18:43:52 -0500, Tom Lane <[email protected]> wrote in 
> sirisha chamarthi <[email protected]> writes:
> > On Wed, Oct 19, 2022 at 7:59 PM Kyotaro Horiguchi <[email protected]>
> > wrote:
> >> In short, the proposed fix alone seems fine to me. If we want to show
> >> further details, I would add a bit as follows.
> >> 
> >> | * * WALAVAIL_REMOVED means it has been removed. A replication stream on
> >> | *   a slot with this LSN cannot continue.  Note that the affected
> >> | *   processes have been terminated by checkpointer, too.
> 
> > Thanks for your comments! Attached the patch with your suggestions.
> 
> Pushed with a bit of additional wordsmithing.  I thought "have been"

Thanks!

> was a bit too strong of an assertion considering that this function
> does not pay any attention to the actual state of any processes,
> so I made it say "should have been".

I think you're correct here.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox