public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: sirisha chamarthi <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value
Date: Thu, 19 Jan 2023 18:43:52 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKrAKeWNYVS8aatr94ohKKwA10-dWsBbK=qYZKZnFhRxpWfi7A@mail.gmail.com>
References: <CAKrAKeXt-=bgm=d+EDmcC9kWoikp8kbVb3LH0K3K+AGGsykpHQ@mail.gmail.com>
	<CALj2ACUtyW94TF76WEM-2JvMMD1a1PzLuaW5Qd9rrKRgnMAZnw@mail.gmail.com>
	<[email protected]>
	<CAKrAKeWNYVS8aatr94ohKKwA10-dWsBbK=qYZKZnFhRxpWfi7A@mail.gmail.com>

sirisha chamarthi <[email protected]> writes:
> On Wed, Oct 19, 2022 at 7:59 PM Kyotaro Horiguchi <[email protected]>
> wrote:
>> In short, the proposed fix alone seems fine to me. If we want to show
>> further details, I would add a bit as follows.
>> 
>> | * * WALAVAIL_REMOVED means it has been removed. A replication stream on
>> | *   a slot with this LSN cannot continue.  Note that the affected
>> | *   processes have been terminated by checkpointer, too.

> Thanks for your comments! Attached the patch with your suggestions.

Pushed with a bit of additional wordsmithing.  I thought "have been"
was a bit too strong of an assertion considering that this function
does not pay any attention to the actual state of any processes,
so I made it say "should have been".

			regards, tom lane

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox