agora inbox for pgsql-hackers@postgresql.org  
help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tgl@sss.pgh.pa.us
Cc: houzj.fnst@fujitsu.com
Cc: amit.kapila16@gmail.com
Cc: m.melihmutlu@gmail.com
Cc: thomas.munro@gmail.com
Cc: kuroda.hayato@fujitsu.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
Date: Wed, 25 Jan 2023 09:57:29 -0800
Message-ID: <20230125175729.GA1098626@nathanxps13> (raw)
In-Reply-To: <20230125.161200.735003108705492225.horikyota.ntt@gmail.com>
References: <20230124171329.GA677220@nathanxps13>
	<2268133.1674584035@sss.pgh.pa.us>
	<20230124184217.GA724858@nathanxps13>
	<20230125.161200.735003108705492225.horikyota.ntt@gmail.com>

On Wed, Jan 25, 2023 at 04:12:00PM +0900, Kyotaro Horiguchi wrote:
> At Tue, 24 Jan 2023 10:42:17 -0800, Nathan Bossart <nathandbossart@gmail.com> wrote in 
>> Here is a first attempt at a patch.  I scanned through all the existing
>> uses of InvalidDsaPointer and DSM_HANDLE_INVALID and didn't notice anything
>> else that needed adjusting.
> 
> There seems to be two cases for DSA_HANDLE_INVALID in dsa_get_handle
> and dsa_attach_in_place, one of which is Assert(), though.

Ah, sorry, I'm not sure how I missed this.  Thanks for looking.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (77+ messages)  latest in thread

Message-ID: <20230125175729.GA1098626@nathanxps13>
Permalink:  ../20230125175729.GA1098626@nathanxps13/
Also on:    postgresql.org/message-id/20230125175729.GA1098626@nathanxps13

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us, houzj.fnst@fujitsu.com, amit.kapila16@gmail.com, m.melihmutlu@gmail.com, thomas.munro@gmail.com, kuroda.hayato@fujitsu.com
  Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
  In-Reply-To: <20230125175729.GA1098626@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox