pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Greg Stark <stark@mit.edu>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: PATCH: Using BRIN indexes for sorted output
Date: Thu, 16 Feb 2023 10:10:16 -0600
Message-ID: <20230216161016.GV1653@telsasoft.com> (raw)
In-Reply-To: <e0b6e395-3ab7-6021-b058-3c5901912b36@enterprisedb.com>
References: <1607e037-8c5b-1626-9f98-496f067b9eb5@enterprisedb.com>
	<CAEze2WgN9LhrrZD3kTHw28sTty5Zc6AYMyFqROJ9wmKH0eF6yw@mail.gmail.com>
	<0695af03-8bd3-f032-47aa-0657135ce45d@enterprisedb.com>
	<CAEze2Wi7S7bMeUpMyBbnGLrFgcWQTDN1edSXYcd8WixeBj9B_w@mail.gmail.com>
	<87964cda-e440-8759-2838-bc4628072a18@enterprisedb.com>
	<CAM-w4HMirdJ-c4chCZhni_T=9R65z2Zm3Ajg5mBrQ9s6OufZXQ@mail.gmail.com>
	<14568731-ac91-ce2d-1477-0e2504c72775@enterprisedb.com>
	<20221206185143.ivy3afwmkhloksgv@awork3.anarazel.de>
	<4e679562-fd9a-33a3-ce71-cd7a27525f8e@enterprisedb.com>
	<e0b6e395-3ab7-6021-b058-3c5901912b36@enterprisedb.com>

On Thu, Feb 16, 2023 at 03:07:59PM +0100, Tomas Vondra wrote:
> Rebased version of the patches, fixing only minor conflicts.

Per cfbot, the patch fails on 32 bit builds.
+ERROR:  count mismatch: 0 != 1000

And causes warnings in mingw cross-compile.

On Sun, Oct 23, 2022 at 11:32:37PM -0500, Justin Pryzby wrote:
> I think new GUCs should be enabled during patch development.
> Maybe in a separate 0002 patch "for CI only not for commit".
> That way "make check" at least has a chance to hit that new code
> paths.
> 
> Also, note that indxpath.c had the var initialized to true.

In your patch, the amstats guc is still being set to false during
startup by the guc machinery.  And the tests crash everywhere if it's
set to on:

TRAP: failed Assert("(nmatches_unique >= 1) && (nmatches_unique <= unique[nvalues-1])"), File: "../src/backend/access/brin/brin_minmax.c", Line: 644, PID: 25519

>  . Some typos in your other patches: "heuristics heuristics".  ste.
>    lest (least).

These are still present.

-- 
Justin





view thread (60+ messages)  latest in thread

Message-ID: <20230216161016.GV1653@telsasoft.com>
Permalink:  ../20230216161016.GV1653@telsasoft.com/
Also on:    postgresql.org/message-id/20230216161016.GV1653@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, tomas.vondra@enterprisedb.com, andres@anarazel.de, stark@mit.edu, boekewurm+postgres@gmail.com, zyu@yugabyte.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: PATCH: Using BRIN indexes for sorted output
  In-Reply-To: <20230216161016.GV1653@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox