pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedmeson vs make: missing/inconsistent ENV
10+ messages / 5 participants
[nested] [flat]
Commits from this thread:
2023-03-09 8bf826528a meson: tests: Adjust with_icu/ZSTD env vars for pg_dump, pg_basebackup
* meson vs make: missing/inconsistent ENV
@ 2023-02-26 22:52 Justin Pryzby <pryzby@telsasoft.com>
0 siblings, 1 reply; 10+ messages in thread
From: Justin Pryzby @ 2023-02-26 22:52 UTC (permalink / raw)
To: pgsql-hackers; +Cc: Peter Eisentraut <peter@eisentraut.org>; Andres Freund <andres@anarazel.de>
I noticed warnings:
Use of uninitialized value $ENV{"with_icu"} in string eq at /home/pryzbyj/src/postgres/src/bin/pg_dump/t/002_pg_dump.pl line 56.
and looked through: git grep ^export '*/Makefile'
and found that:
src/bin/pg_dump/meson.build is missing with_icu since 396d348b0
Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but
it's not in ./Makefile ?? Maybe that was for consistency with other
places, or pre-emptive in case the tap tests want to do tests involving
the ZSTD tool. But it'd be better if ./Makefile had it too.
The rest I think are not errors:
src/test/meson.build is missing PG_TEST_EXTRA
src/bin/pg_upgrade/meson.build and ../src/test/recovery/meson.build
are missing REGRESS_SHLIB
Is there any consideration of promoting these or other warnings to
fatal?
--
Justin
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: meson vs make: missing/inconsistent ENV
@ 2023-02-26 23:21 Andres Freund <andres@anarazel.de>
parent: Justin Pryzby <pryzby@telsasoft.com>
0 siblings, 2 replies; 10+ messages in thread
From: Andres Freund @ 2023-02-26 23:21 UTC (permalink / raw)
To: Justin Pryzby <pryzby@telsasoft.com>; +Cc: pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
Hi,
On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote:
> I noticed warnings:
> Use of uninitialized value $ENV{"with_icu"} in string eq at /home/pryzbyj/src/postgres/src/bin/pg_dump/t/002_pg_dump.pl line 56.
>
> and looked through: git grep ^export '*/Makefile'
>
> and found that:
> src/bin/pg_dump/meson.build is missing with_icu since 396d348b0
Looks like it.
> Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but
> it's not in ./Makefile ?? Maybe that was for consistency with other
> places, or pre-emptive in case the tap tests want to do tests involving
> the ZSTD tool. But it'd be better if ./Makefile had it too.
I suspect I just over-eagerly added it when the pg_basebackup zstd support
went in, using the GZIP_PROGRAM/LZ4 cases as a template. And foolishly
assuming a newly added compression method would be tested.
> The rest I think are not errors:
>
> src/test/meson.build is missing PG_TEST_EXTRA
> src/bin/pg_upgrade/meson.build and ../src/test/recovery/meson.build
> are missing REGRESS_SHLIB
Yep, these are added in the top-level meson.build.
> Is there any consideration of promoting these or other warnings to
> fatal?
You mean the perl warnings?
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: meson vs make: missing/inconsistent ENV
@ 2023-02-27 02:00 Justin Pryzby <pryzby@telsasoft.com>
parent: Andres Freund <andres@anarazel.de>
1 sibling, 1 reply; 10+ messages in thread
From: Justin Pryzby @ 2023-02-27 02:00 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
> > Is there any consideration of promoting these or other warnings to
> > fatal?
>
> You mean the perl warnings?
Yes - it'd be nice if the warnings caused an obvious failure to allow
addressing the issue. I noticed the icu warning while looking at a bug
in 0da243fed, and updating to add ZSTD.
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: meson vs make: missing/inconsistent ENV
@ 2023-02-27 11:17 Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
parent: Justin Pryzby <pryzby@telsasoft.com>
0 siblings, 2 replies; 10+ messages in thread
From: Dagfinn Ilmari Mannsåker @ 2023-02-27 11:17 UTC (permalink / raw)
To: Justin Pryzby <pryzby@telsasoft.com>; +Cc: Andres Freund <andres@anarazel.de>; pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
Justin Pryzby <pryzby@telsasoft.com> writes:
> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
>> > Is there any consideration of promoting these or other warnings to
>> > fatal?
>>
>> You mean the perl warnings?
>
> Yes - it'd be nice if the warnings caused an obvious failure to allow
> addressing the issue. I noticed the icu warning while looking at a bug
> in 0da243fed, and updating to add ZSTD.
Perl warnings can be made fatal with `use warnings FATAL =>
<categories>;`, but one should be careful about which categories to
fatalise, per <https://metacpan.org/pod/warnings#Fatal-Warnings;.
Some categories are inherently unsafe to fatalise, as documented in
<https://metacpan.org/pod/strictures#CATEGORY-SELECTIONS;.
- ilmari
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: meson vs make: missing/inconsistent ENV
@ 2023-02-27 12:30 Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
parent: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
1 sibling, 0 replies; 10+ messages in thread
From: Dagfinn Ilmari Mannsåker @ 2023-02-27 12:30 UTC (permalink / raw)
To: Justin Pryzby <pryzby@telsasoft.com>; +Cc: Andres Freund <andres@anarazel.de>; pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> writes:
> Justin Pryzby <pryzby@telsasoft.com> writes:
>
>> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
>>> > Is there any consideration of promoting these or other warnings to
>>> > fatal?
>>>
>>> You mean the perl warnings?
>>
>> Yes - it'd be nice if the warnings caused an obvious failure to allow
>> addressing the issue. I noticed the icu warning while looking at a bug
>> in 0da243fed, and updating to add ZSTD.
>
> Perl warnings can be made fatal with `use warnings FATAL =>
> <categories>;`, but one should be careful about which categories to
> fatalise, per <https://metacpan.org/pod/warnings#Fatal-Warnings;.
>
> Some categories are inherently unsafe to fatalise, as documented in
> <https://metacpan.org/pod/strictures#CATEGORY-SELECTIONS;.
One disadvantage of making the warnings fatal is that it immediately
aborts the test. Another option would be to to turn warnings into test
failures, à la https://metacpan.org/pod/Test::Warnings or
https://metacpan.org/pod/Test::FailWarnings. Both those modules support
all the Perl versions we do, and have no non-core dependencies, but if
we don't want to add any more dependencies we can incorporate the logic
into one of our own testing modules.
- ilmari
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: meson vs make: missing/inconsistent ENV
@ 2023-02-27 12:33 Andrew Dunstan <andrew@dunslane.net>
parent: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
1 sibling, 1 reply; 10+ messages in thread
From: Andrew Dunstan @ 2023-02-27 12:33 UTC (permalink / raw)
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>; Justin Pryzby <pryzby@telsasoft.com>; +Cc: Andres Freund <andres@anarazel.de>; pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
On 2023-02-27 Mo 06:17, Dagfinn Ilmari Mannsåker wrote:
> Justin Pryzby<pryzby@telsasoft.com> writes:
>
>> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
>>>> Is there any consideration of promoting these or other warnings to
>>>> fatal?
>>> You mean the perl warnings?
>> Yes - it'd be nice if the warnings caused an obvious failure to allow
>> addressing the issue. I noticed the icu warning while looking at a bug
>> in 0da243fed, and updating to add ZSTD.
> Perl warnings can be made fatal with `use warnings FATAL =>
> <categories>;`, but one should be careful about which categories to
> fatalise, per<https://metacpan.org/pod/warnings#Fatal-Warnings;.
>
> Some categories are inherently unsafe to fatalise, as documented in
> <https://metacpan.org/pod/strictures#CATEGORY-SELECTIONS;.
>
Yeah.
It would be nice if there were some fuller explanation of the various
categories, but I don't know of one.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: meson vs make: missing/inconsistent ENV
@ 2023-02-27 13:36 Andrew Dunstan <andrew@dunslane.net>
parent: Andrew Dunstan <andrew@dunslane.net>
0 siblings, 0 replies; 10+ messages in thread
From: Andrew Dunstan @ 2023-02-27 13:36 UTC (permalink / raw)
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>; Justin Pryzby <pryzby@telsasoft.com>; +Cc: Andres Freund <andres@anarazel.de>; pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
On 2023-02-27 Mo 07:33, Andrew Dunstan wrote:
>
>
> On 2023-02-27 Mo 06:17, Dagfinn Ilmari Mannsåker wrote:
>> Justin Pryzby<pryzby@telsasoft.com> writes:
>>
>>> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
>>>>> Is there any consideration of promoting these or other warnings to
>>>>> fatal?
>>>> You mean the perl warnings?
>>> Yes - it'd be nice if the warnings caused an obvious failure to allow
>>> addressing the issue. I noticed the icu warning while looking at a bug
>>> in 0da243fed, and updating to add ZSTD.
>> Perl warnings can be made fatal with `use warnings FATAL =>
>> <categories>;`, but one should be careful about which categories to
>> fatalise, per<https://metacpan.org/pod/warnings#Fatal-Warnings;.
>>
>> Some categories are inherently unsafe to fatalise, as documented in
>> <https://metacpan.org/pod/strictures#CATEGORY-SELECTIONS;.
>>
>
> Yeah.
>
>
> It would be nice if there were some fuller explanation of the various
> categories, but I don't know of one.
>
>
>
Looks like the explanations are in the perldiag manual page.
<https://perldoc.perl.org/perldiag;
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: meson vs make: missing/inconsistent ENV
@ 2023-03-09 00:36 Michael Paquier <michael@paquier.xyz>
parent: Andres Freund <andres@anarazel.de>
1 sibling, 1 reply; 10+ messages in thread
From: Michael Paquier @ 2023-03-09 00:36 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: Justin Pryzby <pryzby@telsasoft.com>; pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
> On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote:
>> Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but
>> it's not in ./Makefile ?? Maybe that was for consistency with other
>> places, or pre-emptive in case the tap tests want to do tests involving
>> the ZSTD tool. But it'd be better if ./Makefile had it too.
>
> I suspect I just over-eagerly added it when the pg_basebackup zstd support
> went in, using the GZIP_PROGRAM/LZ4 cases as a template. And foolishly
> assuming a newly added compression method would be tested.
leaving the discussion with the perl warnings aside for the moment,
these still need to be adjusted. Justin, would you like to write a
patch with everything you have found?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: meson vs make: missing/inconsistent ENV
@ 2023-03-09 01:59 Andres Freund <andres@anarazel.de>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 10+ messages in thread
From: Andres Freund @ 2023-03-09 01:59 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: Justin Pryzby <pryzby@telsasoft.com>; pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
Hi,
On 2023-03-09 09:36:52 +0900, Michael Paquier wrote:
> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
> > On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote:
> >> Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but
> >> it's not in ./Makefile ?? Maybe that was for consistency with other
> >> places, or pre-emptive in case the tap tests want to do tests involving
> >> the ZSTD tool. But it'd be better if ./Makefile had it too.
> >
> > I suspect I just over-eagerly added it when the pg_basebackup zstd support
> > went in, using the GZIP_PROGRAM/LZ4 cases as a template. And foolishly
> > assuming a newly added compression method would be tested.
>
> leaving the discussion with the perl warnings aside for the moment,
> these still need to be adjusted. Justin, would you like to write a
> patch with everything you have found?
I now pushed a fix for the two obvious cases pointed out by Justin.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: meson vs make: missing/inconsistent ENV
@ 2023-03-09 03:21 Michael Paquier <michael@paquier.xyz>
parent: Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 10+ messages in thread
From: Michael Paquier @ 2023-03-09 03:21 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: Justin Pryzby <pryzby@telsasoft.com>; pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
On Wed, Mar 08, 2023 at 05:59:13PM -0800, Andres Freund wrote:
> I now pushed a fix for the two obvious cases pointed out by Justin.
Thanks!
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 10+ messages in thread
end of thread, other threads:[~2023-03-09 03:21 UTC | newest]
Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-02-26 22:52 meson vs make: missing/inconsistent ENV Justin Pryzby <pryzby@telsasoft.com>
2023-02-26 23:21 ` Andres Freund <andres@anarazel.de>
2023-02-27 02:00 ` Justin Pryzby <pryzby@telsasoft.com>
2023-02-27 11:17 ` Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
2023-02-27 12:30 ` Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
2023-02-27 12:33 ` Andrew Dunstan <andrew@dunslane.net>
2023-02-27 13:36 ` Andrew Dunstan <andrew@dunslane.net>
2023-03-09 00:36 ` Michael Paquier <michael@paquier.xyz>
2023-03-09 01:59 ` Andres Freund <andres@anarazel.de>
2023-03-09 03:21 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox