From: Sandro Santilli <strk@kbt.io>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Regina Obe <r@pcorp.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
Date: Wed, 8 Mar 2023 13:27:36 +0100
Message-ID: <20230308122736.e2mx4e3paxbabcnw@c19> (raw)
In-Reply-To: <CA+TgmobDy0sasmzOFkCcKXC3XeQZzRNwbaQRJ752tF1i11BRKQ@mail.gmail.com>
References: <YgakFklJyM5pNdt+@c19>
<20221117095734.igldlk6kngr6ogim@c19>
<166914379479.1121.7549798686571352890.pgcf@coridan.postgresql.org>
<55512.1673304709@sss.pgh.pa.us>
<20230110205259.htcuhg3t7shd367d@c19>
<387183.1673394631@sss.pgh.pa.us>
<CA+TgmobDy0sasmzOFkCcKXC3XeQZzRNwbaQRJ752tF1i11BRKQ@mail.gmail.com>
On Tue, Mar 07, 2023 at 12:39:34PM -0500, Robert Haas wrote:
> The thing that confuses me here is why the PostGIS folks are ending up
> with so many files.
We want to allow PostGIS users to upgrade from ANY previous version,
because different distribution or user habit may result in people
upgrading from ANY older release to the newest.
Now, PostGIS has released a total of 164 versions:
curl -s https://download.osgeo.org/postgis/source/ |
grep -c '.tar.gz<'
In *addition* to these, most developers end up installing a "dev"
suffixed version to distinguish it from the official releases,
which means there's a total of 164*2 = 328 version *per extension*.
Now, PostGIS doesn't install a single extension but multiple ones:
- postgis
- postgis_raster
- postgis_topology
- postgis_sfcgal
- postgis_tiger_geocoder
- address_standardizer
So we'd be up to 328 * 6 = 1968 files needed to upgrade from ANY
postgis extension version to CURRENT version.
The numbers are slightly less because not all versions of PostGIS
did support EXTENSION (wasn't even available in early PostGIS versions)
> We certainly don't have that problem with the
> extension that are being maintained in contrib, and I guess there is
> some difference in versioning practice that is making it an issue for
> them but not for us. I wish I understood what was going on there.
Our extension versioning has 3 numbers, but PostgreSQL doesn't really
care about this right ? It's just that we've had 328 different
versions released and more are to come, and we want users to be able
to upgrade from each one of them.
I guess you may suggest that we do NOT increas the *EXTENSION* version
number UNLESS something really changes at SQL level, but honestly I
doubt we EVER released a version with no changes at the SQL level
(maybe in some occasion for really bad bugs which were only fixed at
the C level).
--strk;
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: strk@kbt.io, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, r@pcorp.us, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
In-Reply-To: <20230308122736.e2mx4e3paxbabcnw@c19>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox