pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: thomas.munro@gmail.com
Cc: tgl@sss.pgh.pa.us
Cc: john.naylor@enterprisedb.com
Cc: noriyoshi.shinoda@hpe.com
Cc: jchampion@timescale.com
Cc: sawada.mshk@gmail.com
Cc: masao.fujii@oss.nttdata.com
Cc: pgsql-hackers@postgresql.org
Cc: rjuju123@gmail.com
Subject: Re: Improve logging when using Huge Pages
Date: Thu, 9 Mar 2023 11:46:08 -0800
Message-ID: <20230309194608.GA3703826@nathanxps13> (raw)
In-Reply-To: <ZAoLoCPRf6j/HyQp@telsasoft.com>
References: <20230208231803.GP1653@telsasoft.com>
	<20230209094013.67varf63bihops33@alvherre.pgsql>
	<20230209192909.GA606606@nathanxps13>
	<20230213232245.GI1653@telsasoft.com>
	<20230214041852.GA1190218@nathanxps13>
	<20230215013256.GP1653@telsasoft.com>
	<20230215181317.GA1353037@nathanxps13>
	<20230308221656.GA3621885@nathanxps13>
	<ZAnuYi/Cb8QjRSoN@tamriel.snowman.net>
	<ZAoLoCPRf6j/HyQp@telsasoft.com>

On Thu, Mar 09, 2023 at 10:38:56AM -0600, Justin Pryzby wrote:
> On Thu, Mar 09, 2023 at 09:34:10AM -0500, Stephen Frost wrote:
>> To that end- perhaps this isn't appropriate as a GUC at all?  Why not
>> have this just be a system information function?  Functionally it really
>> provides the same info- if the server is running then you get back
>> either true or false, if it's not then you can't call it but that's
>> hardly different from an unknown or error result.
> 
> We talked about making it a function ~6 weeks ago.
> 
> Is there an agreement to use a function, instead ?

If we're tallying votes, please count me as +1 for a system information
function.  I think that nicely sidesteps having to return "unknown" in some
cases, which I worry will just cause confusion.  IMHO it is much more
obvious that the value refers to the current server if you have to log in
and execute a function to see it.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (93+ messages)  latest in thread

Message-ID: <20230309194608.GA3703826@nathanxps13>
Permalink:  ../20230309194608.GA3703826@nathanxps13/
Also on:    postgresql.org/message-id/20230309194608.GA3703826@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, pryzby@telsasoft.com, sfrost@snowman.net, alvherre@alvh.no-ip.org, andres@anarazel.de, michael@paquier.xyz, horikyota.ntt@gmail.com, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, john.naylor@enterprisedb.com, noriyoshi.shinoda@hpe.com, jchampion@timescale.com, sawada.mshk@gmail.com, masao.fujii@oss.nttdata.com, rjuju123@gmail.com
  Subject: Re: Improve logging when using Huge Pages
  In-Reply-To: <20230309194608.GA3703826@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox