pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Cc: schneider@ardentperf.com
Subject: Re: monitoring usage count distribution
Date: Fri, 7 Apr 2023 17:18:16 -0700
Message-ID: <20230408001816.GA519579@nathanxps13> (raw)
In-Reply-To: <3089322.1680892171@sss.pgh.pa.us>
References: <CA+TgmobrQ90KGN4dwxL8q-LV529gCMmzXiy8CG5eQwjYTPzZLA@mail.gmail.com>
	<20230405175124.GA31516@nathanxps13>
	<CA+TgmoYRHDDJTgPcFkomz4KzzsQHXRJtqKeJyOk4AZNTjf=TnQ@mail.gmail.com>
	<20230405190921.ck7v4y2h3ogoanvg@awork3.anarazel.de>
	<20230405194101.GB105962@nathanxps13>
	<2061855.1680725784@sss.pgh.pa.us>
	<CA+TgmobRvYRxubzHY7PgnuYhJHPBGSF8a-6Ax+cz0Fm0EbxGgA@mail.gmail.com>
	<2478091.1680802355@sss.pgh.pa.us>
	<20230406180608.GA275542@nathanxps13>
	<3089322.1680892171@sss.pgh.pa.us>

On Fri, Apr 07, 2023 at 02:29:31PM -0400, Tom Lane wrote:
> I'm not sure if there is consensus for 0002, but I reviewed and pushed
> 0001.  I made one non-cosmetic change: it no longer skips invalid
> buffers.  Otherwise, the row for usage count 0 would be pretty useless.
> Also it seemed to me that sum(buffers) ought to agree with the
> shared_buffers setting.

Makes sense.  Thanks!

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (20+ messages)

Message-ID: <20230408001816.GA519579@nathanxps13>
Permalink:  ../20230408001816.GA519579@nathanxps13/
Also on:    postgresql.org/message-id/20230408001816.GA519579@nathanxps13

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de, schneider@ardentperf.com
  Subject: Re: monitoring usage count distribution
  In-Reply-To: <20230408001816.GA519579@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox