From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Cc: schneider@ardentperf.com
Subject: Re: monitoring usage count distribution
Date: Wed, 5 Apr 2023 10:51:24 -0700
Message-ID: <20230405175124.GA31516@nathanxps13> (raw)
In-Reply-To: <CA+TgmobrQ90KGN4dwxL8q-LV529gCMmzXiy8CG5eQwjYTPzZLA@mail.gmail.com>
References: <20230130233040.GA2800702@nathanxps13>
<CA+Tgmoa-c3avHFBdko9d7bGQuYXrJhHHjhG1yAs8h-k_sLbyPQ@mail.gmail.com>
<20230404232919.uibzbhjdylk3mlvp@awork3.anarazel.de>
<CA+TgmobrQ90KGN4dwxL8q-LV529gCMmzXiy8CG5eQwjYTPzZLA@mail.gmail.com>
On Wed, Apr 05, 2023 at 09:44:58AM -0400, Robert Haas wrote:
> On Tue, Apr 4, 2023 at 7:29 PM Andres Freund <andres@anarazel.de> wrote:
>> > Replacing that with a six-element integer array would be a clear improvement
>> > and, IMHO, better than adding yet another function to the extension.
>>
>> I'd have no issue with that.
>
> Cool.
The six-element array approach won't show the number of dirty and pinned
buffers for each usage count, but I'm not sure that's a deal-breaker.
Barring objections, I'll post an updated patch shortly with that approach.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, robertmhaas@gmail.com, andres@anarazel.de, schneider@ardentperf.com
Subject: Re: monitoring usage count distribution
In-Reply-To: <20230405175124.GA31516@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox