From: Nathan Bossart <nathandbossart@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: michael@paquier.xyz
Cc: noah@leadboat.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: add non-option reordering to in-tree getopt_long
Date: Wed, 21 Jun 2023 10:56:24 -0700
Message-ID: <20230621175624.GA882103@nathanxps13> (raw)
In-Reply-To: <20230620.141244.1061039848681375358.horikyota.ntt@gmail.com>
References: <20230616045828.GA972663@nathanxps13>
<20230616.165138.1460643839992276252.horikyota.ntt@gmail.com>
<20230616182847.GA71216@nathanxps13>
<20230620.141244.1061039848681375358.horikyota.ntt@gmail.com>
On Tue, Jun 20, 2023 at 02:12:44PM +0900, Kyotaro Horiguchi wrote:
> The argv elements get shuffled around many times with the
> patch. However, I couldn't find a way to decrease the count without
> resorting to a forward scan. So I've concluded the current approach
> is them most effeicient, considering the complexity.
Yeah, I'm not sure it's worth doing anything more sophisticated.
> I tried some patterns with the patch and it generates the same results
> with the glibc version.
>
> The TAP test looks fine and it catches the change.
>
> Everything looks fine to me.
Thanks for reviewing.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, horikyota.ntt@gmail.com, michael@paquier.xyz, noah@leadboat.com
Subject: Re: add non-option reordering to in-tree getopt_long
In-Reply-To: <20230621175624.GA882103@nathanxps13>
References: <20230616045828.GA972663@nathanxps13> <20230616.165138.1460643839992276252.horikyota.ntt@gmail.com> <20230616182847.GA71216@nathanxps13> <20230620.141244.1061039848681375358.horikyota.ntt@gmail.com> <20230621175624.GA882103@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox