pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: noah@leadboat.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: add non-option reordering to in-tree getopt_long
Date: Tue, 19 Dec 2023 10:44:52 -0600
Message-ID: <20231219164452.GA832556@nathanxps13> (raw)
In-Reply-To: <4139302.1702953114@sss.pgh.pa.us>
References: <20230711163232.GA616878@nathanxps13>
	<20230713034903.GA991765@nathanxps13>
	<ZK+OFMbpICfO1aTR@paquier.xyz>
	<20230713145712.GA1049722@nathanxps13>
	<ZLDOrsxEqbV5vVzx@paquier.xyz>
	<20230714043842.GB327716@nathanxps13>
	<ZLDW5HjNS1Ys43xP@paquier.xyz>
	<4007895.1702928482@sss.pgh.pa.us>
	<20231218215201.GA586573@nathanxps13>
	<4139302.1702953114@sss.pgh.pa.us>

On Mon, Dec 18, 2023 at 09:31:54PM -0500, Tom Lane wrote:
> Agreed, if it actually is 19 years old.  I'm wondering a little bit
> if there could be some moderately-recent glibc behavior change
> involved.  I'm not excited enough about it to go trawl their change
> log, but we should keep our ears cocked for similar reports.

From a brief glance, I believe this is long-standing behavior.  Even though
we advance optind at the bottom of the loop, the next getopt_long() call
seems to reset it to the first non-option (which was saved in a previous
call).

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (37+ messages)

Message-ID: <20231219164452.GA832556@nathanxps13>
Permalink:  ../20231219164452.GA832556@nathanxps13/
Also on:    postgresql.org/message-id/20231219164452.GA832556@nathanxps13

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, michael@paquier.xyz, horikyota.ntt@gmail.com, noah@leadboat.com
  Subject: Re: add non-option reordering to in-tree getopt_long
  In-Reply-To: <20231219164452.GA832556@nathanxps13>
  References: <20230711163232.GA616878@nathanxps13> <20230713034903.GA991765@nathanxps13> <ZK+OFMbpICfO1aTR@paquier.xyz> <20230713145712.GA1049722@nathanxps13> <ZLDOrsxEqbV5vVzx@paquier.xyz> <20230714043842.GB327716@nathanxps13> <ZLDW5HjNS1Ys43xP@paquier.xyz> <4007895.1702928482@sss.pgh.pa.us> <20231218215201.GA586573@nathanxps13> <4139302.1702953114@sss.pgh.pa.us> <20231219164452.GA832556@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox