From: Nathan Bossart <nathandbossart@gmail.com>
To: Kirk Wolak <wolakk@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Eric Radman <ericshane@eradman.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Add function to_oct
Date: Tue, 25 Jul 2023 17:16:56 -0700
Message-ID: <20230726001656.GC2992317@nathanxps13> (raw)
In-Reply-To: <20230725232426.GA2992317@nathanxps13>
References: <Y6IyTQQ/TsD5wnsH@vm3.eradman.com>
<5c260f97-d8c8-4a68-7498-022e550c6b10@enterprisedb.com>
<CACLU5mQ9BGiMaTbS+EpvxngdEf35aX+Tcs31K8UJMkbxaZh5JA@mail.gmail.com>
<20230725232426.GA2992317@nathanxps13>
On Tue, Jul 25, 2023 at 04:24:26PM -0700, Nathan Bossart wrote:
> I started taking a look at this and ended up adding to_binary() and a
> bigint version of to_oct() for completeness. While I was at it, I moved
> the base-conversion logic out to a separate static function that
> to_binary/oct/hex all use.
Bleh, this patch seems to fail horribly on 32-bit builds. I'll look into
it soon.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, wolakk@gmail.com, peter.eisentraut@enterprisedb.com, ericshane@eradman.com
Subject: Re: [PATCH] Add function to_oct
In-Reply-To: <20230726001656.GC2992317@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox