pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dave Cramer <davecramer@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Using defines for protocol characters
Date: Mon, 7 Aug 2023 14:47:14 -0700
Message-ID: <20230807214714.GA1284531@nathanxps13> (raw)
In-Reply-To: <859245.1691438528@sss.pgh.pa.us>
References: <CAHut+PuE-3tc_6m06bwnjftk2KBM728ZSDhuL1_=vRCfEGMZ1A@mail.gmail.com>
	<20230807091044.jjgsl2rgheazaung@alvherre.pgsql>
	<CADK3HH+aXM82oY-tUzidBS1bfqoUFubVxygmFaBFZFV=3iHYdw@mail.gmail.com>
	<CA+TgmoZ=XfKEqiq80SbN0R_XpLnnkgjGuO5WBTL0nYTseKD4TQ@mail.gmail.com>
	<838284.1691432698@sss.pgh.pa.us>
	<CA+TgmoYhA4Df2euFVK24NU9qkcHZBfbJTsr9M=4UWsr+sayD8Q@mail.gmail.com>
	<CADK3HHJBmf5YgbW4bnSA5kBawgrZxyxDa2xQJDFHoGdC6hhEgg@mail.gmail.com>
	<859245.1691438528@sss.pgh.pa.us>

On Mon, Aug 07, 2023 at 04:02:08PM -0400, Tom Lane wrote:
> Dave Cramer <davecramer@gmail.com> writes:
>> On Mon, 7 Aug 2023 at 12:59, Robert Haas <robertmhaas@gmail.com> wrote:
>>> PqMsgEmptyQueryResponse or something like that seems better, if we
>>> want to keep the current capitalization. I'm not a huge fan of the way
>>> we vary our capitalization conventions so much all over the code base,
>>> but I think we would at least do well to keep it consistent from one
>>> end of a certain identifier to the other.
> 
>> I don't have a strong preference, but before I make the changes I'd like to
>> get consensus.
>> Can we vote or whatever it takes to decide on a naming pattern that is
>> acceptable ?
> 
> I'm good with Robert's proposal above.

+1

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (47+ messages)  latest in thread

Message-ID: <20230807214714.GA1284531@nathanxps13>
Permalink:  ../20230807214714.GA1284531@nathanxps13/
Also on:    postgresql.org/message-id/20230807214714.GA1284531@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, davecramer@gmail.com, robertmhaas@gmail.com, alvherre@alvh.no-ip.org, smithpb2250@gmail.com, ishii@sraoss.co.jp, pgsql-hackers@lists.postgresql.org
  Subject: Re: Using defines for protocol characters
  In-Reply-To: <20230807214714.GA1284531@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox