pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Brown <michael.brown@discourse.org>
Cc: pgsql-hackers@postgresql.org
Subject: Re: should frontend tools use syncfs() ?
Date: Tue, 8 Aug 2023 13:06:06 -0700
Message-ID: <20230808200606.GA1384393@nathanxps13> (raw)
In-Reply-To: <20230801163707.GA862840@nathanxps13>
References: <20210930004340.GM831@telsasoft.com>
	<YVUz0Ay9KshniWBe@paquier.xyz>
	<20220413115412.GM26620@telsasoft.com>
	<20230729214010.GA189456@nathanxps13>
	<20230731175138.GA432880@nathanxps13>
	<20230731183946.GB537853@nathanxps13>
	<20230801163707.GA862840@nathanxps13>

I ran a couple of tests for pg_upgrade with 100k tables (created using the
script here [0]) in order to demonstrate the potential benefits of this
patch.

pg_upgrade --sync-method fsync
    real    5m50.072s
    user    0m10.606s
    sys     0m40.298s

pg_upgrade --sync-method syncfs
    real    3m44.096s
    user    0m8.906s
    sys     0m26.398s

pg_upgrade --no-sync
    real    3m27.697s
    user    0m9.056s
    sys     0m26.605s

[0] https://postgr.es/m/3612876.1689443232%40sss.pgh.pa.us

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (50+ messages)  latest in thread

Message-ID: <20230808200606.GA1384393@nathanxps13>
Permalink:  ../20230808200606.GA1384393@nathanxps13/
Also on:    postgresql.org/message-id/20230808200606.GA1384393@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, pryzby@telsasoft.com, michael@paquier.xyz, thomas.munro@gmail.com, david@pgmasters.net, masao.fujii@oss.nttdata.com, bruce@momjian.us, tgl@sss.pgh.pa.us, michael.brown@discourse.org
  Subject: Re: should frontend tools use syncfs() ?
  In-Reply-To: <20230808200606.GA1384393@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox