From: Nathan Bossart <nathandbossart@gmail.com>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: alvherre@alvh.no-ip.org
Cc: davecramer@gmail.com
Cc: tgl@sss.pgh.pa.us
Cc: peter@eisentraut.org
Cc: robertmhaas@gmail.com
Cc: smithpb2250@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Using defines for protocol characters
Date: Tue, 15 Aug 2023 08:58:02 -0700
Message-ID: <20230815155802.GA2298234@nathanxps13> (raw)
In-Reply-To: <20230815.144624.47861227022067018.t-ishii@sranhm.sra.co.jp>
References: <20230809165147.GA1385791@nathanxps13>
<20230809170805.6ugrqutmg7qfmn22@alvherre.pgsql>
<20230815040727.GA2294364@nathanxps13>
<20230815.144624.47861227022067018.t-ishii@sranhm.sra.co.jp>
On Tue, Aug 15, 2023 at 02:46:24PM +0900, Tatsuo Ishii wrote:
> Is it possible to put the new define staff into protocol.h then let
> pqcomm.h include protocol.h? This makes Pgpool-II and other middle
> ware/drivers written in C easier to use the defines so that they only
> include protocol.h to use the defines.
It is possible, of course, but are there any reasons such programs couldn't
include pqcomm.h? It looks relatively inexpensive to me. That being said,
I'm fine with the approach you describe if the folks in this thread agree.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, ishii@sraoss.co.jp, alvherre@alvh.no-ip.org, davecramer@gmail.com, tgl@sss.pgh.pa.us, peter@eisentraut.org, robertmhaas@gmail.com, smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Using defines for protocol characters
In-Reply-To: <20230815155802.GA2298234@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox