pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Jelte Fennema <postgres@jeltef.nl>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: shiy.fnst@fujitsu.com <shiy.fnst@fujitsu.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Noah Misch <noah@leadboat.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Jesse Zhang <sbjesse@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Thu, 17 Aug 2023 07:40:41 -0700
Message-ID: <20230817144041.GA3099457@nathanxps13> (raw)
In-Reply-To: <CAH2-Wz=tqQRqqHGZv17=a3xjf-Mur0pX4qrnt++wNohWbe6DWg@mail.gmail.com>
References: <e89d122e-6cf6-d0dc-8fe9-1dfa1de8dcab@dunslane.net>
	<CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com>
	<ZEOfzsDrQ1SMOj4Q@paquier.xyz>
	<582c503b-cd98-1891-ff87-9c8e8ce73ee5@dunslane.net>
	<CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com>
	<30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net>
	<1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net>
	<CAH2-WznOKBQ3HvdwvyXHz18T2u-brkE5umDUic4B-2vtavJKqA@mail.gmail.com>
	<20230815203109.GA2596919@nathanxps13>
	<CAH2-Wz=tqQRqqHGZv17=a3xjf-Mur0pX4qrnt++wNohWbe6DWg@mail.gmail.com>

On Wed, Aug 16, 2023 at 01:15:55PM -0700, Peter Geoghegan wrote:
> On Tue, Aug 15, 2023 at 1:31 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> Should we add those?  Patch attached.
> 
> I think that that makes sense.

Committed.

> I just don't want to normalize updating
> .git-blame-ignore-revs very frequently. (Actually, it's more like I
> don't want to normalize any scheme that makes updating the ignore list
> very frequently start to seem reasonable.)

Agreed.  I've found myself habitually running pgindent since becoming a
committer, but I'm sure I'll forget it one of these days.  From a quick
skim of this thread, it sounds like a pre-commit hook [0] might be the best
option at the moment.

[0] https://wiki.postgresql.org/wiki/Working_with_Git#Using_git_hooks

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (308+ messages)  latest in thread

Message-ID: <20230817144041.GA3099457@nathanxps13>
Permalink:  ../20230817144041.GA3099457@nathanxps13/
Also on:    postgresql.org/message-id/20230817144041.GA3099457@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, pg@bowt.ie, andrew@dunslane.net, postgres@jeltef.nl, michael@paquier.xyz, shiy.fnst@fujitsu.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, pryzby@telsasoft.com, andres@anarazel.de, noah@leadboat.com, bruce@momjian.us, magnus@hagander.net, alvherre@2ndquadrant.com, sfrost@snowman.net, sbjesse@gmail.com, peter.eisentraut@enterprisedb.com
  Subject: Re: run pgindent on a regular basis / scripted manner
  In-Reply-To: <20230817144041.GA3099457@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox