pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Inefficiency in parallel pg_restore with many tables
Date: Fri, 1 Sep 2023 10:05:46 -0700
Message-ID: <20230901170546.GC3178187@nathanxps13> (raw)
In-Reply-To: <20230725185336.GA2911441@nathanxps13>
References: <20230718045701.GA1090171@nathanxps13>
	<20230718160511.loirkf5fwjm5ut73@alvherre.pgsql>
	<20230718160713.GA1139177@nathanxps13>
	<20230720190644.GA1724613@nathanxps13>
	<20230722231941.GA2020225@nathanxps13>
	<1225141.1690069670@sss.pgh.pa.us>
	<20230723055703.GA2421212@nathanxps13>
	<20230724190015.GA2528613@nathanxps13>
	<20230725185336.GA2911441@nathanxps13>

On Tue, Jul 25, 2023 at 11:53:36AM -0700, Nathan Bossart wrote:
> Here is a polished patch set for this approach.  I've also added a 0004
> that replaces the open-coded heap in pg_dump_sort.c with a binaryheap.
> IMHO these patches are in decent shape.

I'm hoping to commit these patches at some point in the current commitfest.
I don't sense anything tremendously controversial, and they provide a
pretty nice speedup in some cases.  Are there any remaining concerns?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (37+ messages)  latest in thread

Message-ID: <20230901170546.GC3178187@nathanxps13>
Permalink:  ../20230901170546.GC3178187@nathanxps13/
Also on:    postgresql.org/message-id/20230901170546.GC3178187@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
  Subject: Re: Inefficiency in parallel pg_restore with many tables
  In-Reply-To: <20230901170546.GC3178187@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox