pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Gregory Stark (as CFM) <stark.cfm@gmail.com>
Cc: David Geier <geidav.pg@gmail.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Marcos Pegoraro <marcos@f10.com.br>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: David Steele <david@pgmasters.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Pavel Trukhanov <pavel.trukhanov@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pg_stat_statements and "IN" conditions
Date: Fri, 13 Oct 2023 11:37:30 -0500
Message-ID: <20231013163730.GA1362765@nathanxps13> (raw)
In-Reply-To: <20230704190256.arszjcwvrjekxj25@ddolgov.remote.csb>
References: <20230211120820.y7krq37jubnjsa5b@erthalion.local>
	<07919318-6c35-a13f-6a1d-98686a3e38de@gmail.com>
	<20230217154602.uf3a3cgqeoeysycz@erthalion.local>
	<8702fa3e-5aac-dcf0-161b-faa2b9eadad6@gmail.com>
	<20230226104619.jfmwrpd5zrkmp3eu@erthalion.local>
	<CAM-w4HO29FpoX5oYR7tuxP9sZA1s3zLV94c_79h_uQeNHUjhyQ@mail.gmail.com>
	<20230314190432.l4oe3wa3pvt5b7hx@erthalion.local>
	<20230319122734.xkba536kut3g4gcy@erthalion.local>
	<20230704044611.GA3373000@nathanxps13>
	<20230704190256.arszjcwvrjekxj25@ddolgov.remote.csb>

On Tue, Jul 04, 2023 at 09:02:56PM +0200, Dmitry Dolgov wrote:
>> On Mon, Jul 03, 2023 at 09:46:11PM -0700, Nathan Bossart wrote:
>> Also, it seems counterintuitive that queries with fewer than 10
>> constants are not merged.
> 
> Why? What would be your intuition using this feature?

For the "powers" setting, I would've expected queries with 0-9 constants to
be merged.  Then 10-99, 100-999, 1000-9999, etc.  I suppose there might be
an argument for separating 0 from 1-9, too.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (155+ messages)  latest in thread

Message-ID: <20231013163730.GA1362765@nathanxps13>
Permalink:  ../20231013163730.GA1362765@nathanxps13/
Also on:    postgresql.org/message-id/20231013163730.GA1362765@nathanxps13

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, 9erthalion6@gmail.com, stark.cfm@gmail.com, geidav.pg@gmail.com, sk@zsrv.org, michael@paquier.xyz, alvherre@alvh.no-ip.org, marcos@f10.com.br, vignesh21@gmail.com, robertmhaas@gmail.com, zyu@yugabyte.com, david@pgmasters.net, pavel.trukhanov@gmail.com, tgl@sss.pgh.pa.us
  Subject: Re: pg_stat_statements and "IN" conditions
  In-Reply-To: <20231013163730.GA1362765@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox