From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: verify predefined LWLocks have entries in wait_event_names.txt
Date: Fri, 5 Jan 2024 00:14:15 -0600
Message-ID: <20240105061415.GA2167264@nathanxps13> (raw)
In-Reply-To: <ZZTHsd8-_L76GJ_a@paquier.xyz>
References: <20240102173120.GA1061678@nathanxps13>
<ZZTHsd8-_L76GJ_a@paquier.xyz>
On Wed, Jan 03, 2024 at 11:34:25AM +0900, Michael Paquier wrote:
> On Tue, Jan 02, 2024 at 11:31:20AM -0600, Nathan Bossart wrote:
>> +# Find the location of lwlocknames.h.
>> +my $include_dir = $node->config_data('--includedir');
>> +my $lwlocknames_file = "$include_dir/server/storage/lwlocknames.h";
>
> I am afraid that this is incorrect because an installation could
> decide to install server-side headers in a different path than
> $include/server/. Using --includedir-server would be the correct
> answer, appending "storage/lwlocknames.h" to the path retrieved from
> pg_config.
Ah, good to know, thanks.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, michael@paquier.xyz, robertmhaas@gmail.com
Subject: Re: verify predefined LWLocks have entries in wait_event_names.txt
In-Reply-To: <20240105061415.GA2167264@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox