pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: reorganize "Shared Memory and LWLocks" section of docs
Date: Tue, 16 Jan 2024 08:20:19 -0600
Message-ID: <20240116142019.GA52506@nathanxps13> (raw)
In-Reply-To: <CALj2ACXyCwkcLPowucpVaGZuzd6TDxHfmtpg9=Vca=379RL2Rg@mail.gmail.com>
References: <20240112041430.GA3557928@nathanxps13>
	<CAJ7c6TNC-tC9JS_X_FSShDEeGujrUdunVdtBBm+YGg8VW+AkFg@mail.gmail.com>
	<20240112154650.GA3565306@nathanxps13>
	<20240112172350.GB3803561@nathanxps13>
	<CAJ7c6TOdT9TyUKwx+DgS=MEi48JiscGxoAjuMczKEU8-jMsDpA@mail.gmail.com>
	<20240113212815.GA4065002@nathanxps13>
	<CALj2ACXyCwkcLPowucpVaGZuzd6TDxHfmtpg9=Vca=379RL2Rg@mail.gmail.com>

On Tue, Jan 16, 2024 at 10:02:15AM +0530, Bharath Rupireddy wrote:
> The v3 patch looks good to me except for a nitpick: the input
> parameter for RequestAddinShmemSpace is 'Size' not 'int'
> 
>  <programlisting>
>  void RequestAddinShmemSpace(int size)
>  </programlisting>

Hah, I think this mistake is nearly old enough to vote (e0dece1, 5f78aa5).
Good catch.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (11+ messages)  latest in thread

Message-ID: <20240116142019.GA52506@nathanxps13>
Permalink:  ../20240116142019.GA52506@nathanxps13/
Also on:    postgresql.org/message-id/20240116142019.GA52506@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, bharath.rupireddyforpostgres@gmail.com, aleksander@timescale.com
  Subject: Re: reorganize "Shared Memory and LWLocks" section of docs
  In-Reply-To: <20240116142019.GA52506@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox