pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Abhijit Menon-Sen <ams@toroid.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: introduce dynamic shared memory registry
Date: Mon, 22 Jan 2024 20:46:52 -0600
Message-ID: <20240123024652.GA2251765@nathanxps13> (raw)
In-Reply-To: <CALj2ACVv9ADZ=yBcL3LPT+tkepwujfk_s3mLidzXcE5smpjwfg@mail.gmail.com>
References: <ZaF6UpYImGqVIhVp@toroid.org>
	<20240112194555.GA3804945@nathanxps13>
	<20240113214124.GA4162765@nathanxps13>
	<CALj2ACVKFPm7nCrHMko7JJpsFJU23abzYyMS8S2Pz8r4M=rW7w@mail.gmail.com>
	<20240116160748.GB100542@nathanxps13>
	<CALj2ACWuiAm7Rr13PFfaiQfOHUoCbJOJvU72jyLnj4xfoEOAEg@mail.gmail.com>
	<20240119204636.GA1178173@nathanxps13>
	<3348869.1705854106@sss.pgh.pa.us>
	<20240121221320.GA1682397@nathanxps13>
	<CALj2ACVv9ADZ=yBcL3LPT+tkepwujfk_s3mLidzXcE5smpjwfg@mail.gmail.com>

On Mon, Jan 22, 2024 at 05:00:48PM +0530, Bharath Rupireddy wrote:
> On Mon, Jan 22, 2024 at 3:43 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> Oops.  I've attached an attempt at fixing this.  I took the opportunity to
>> clean up the surrounding code a bit.
> 
> The code looks cleaner and readable with the patch. All the call sites
> are taking care of dsm_attach returning NULL value. So, the attached
> patch looks good to me.

Committed.  Thanks for the report and the reviews.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (51+ messages)

Message-ID: <20240123024652.GA2251765@nathanxps13>
Permalink:  ../20240123024652.GA2251765@nathanxps13/
Also on:    postgresql.org/message-id/20240123024652.GA2251765@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, bharath.rupireddyforpostgres@gmail.com, tgl@sss.pgh.pa.us, ams@toroid.org, michael@paquier.xyz, robertmhaas@gmail.com
  Subject: Re: introduce dynamic shared memory registry
  In-Reply-To: <20240123024652.GA2251765@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox