agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Nathan Bossart <nathandbossart@gmail.com>
To: Mats Kindahl <mats@timescale.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: glibc qsort() vulnerability
Date: Fri, 9 Feb 2024 14:04:29 -0600
Message-ID: <20240209200429.GA665650@nathanxps13> (raw)
In-Reply-To: <CA+14426fF6Mx0cM1vi47WLi3qtkNvtmr7DAkCpqVk0x41P9z-A@mail.gmail.com>
References: <CA+14424k0MbdkJuSSLrr1==PYK+oL5Gtq7siTsMgCs+KcCrEvA@mail.gmail.com>
<20240208183835.GA503311@nathanxps13>
<1074897.1707417842@sss.pgh.pa.us>
<20240208195954.vlpoii4ftoow2of4@awork3.anarazel.de>
<20240208200737.GA504276@nathanxps13>
<1242426.1707424769@sss.pgh.pa.us>
<CA+14425sEcy-KzCE1ztpO=XrHZ5u_5tR2UNsw6874dVbAShpzQ@mail.gmail.com>
<20240209162433.GA663211@nathanxps13>
<1596756.1707496048@sss.pgh.pa.us>
<CA+14426fF6Mx0cM1vi47WLi3qtkNvtmr7DAkCpqVk0x41P9z-A@mail.gmail.com>
On Fri, Feb 09, 2024 at 08:40:47PM +0100, Mats Kindahl wrote:
> On Fri, Feb 9, 2024 at 5:27 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> We do pretty much assume that "int" is "int32". But I agree that
>> assuming anything about the width of size_t is bad. I think we need
>> a separate pg_cmp_size() or pg_cmp_size_t().
>
> Do we want to have something similar for "int" as well? It seems to be
> quite common and even though it usually is an int32, it does not have to be.
I don't think we need separate functions for int and int32. As Tom noted,
we assume they are the same.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
view thread (64+ messages) latest in thread
Message-ID: <20240209200429.GA665650@nathanxps13>
Permalink: ../20240209200429.GA665650@nathanxps13/
Also on: postgresql.org/message-id/20240209200429.GA665650@nathanxps13
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, mats@timescale.com, tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@gmail.com, hlinnaka@iki.fi, pgsql-hackers@lists.postgresql.org
Subject: Re: glibc qsort() vulnerability
In-Reply-To: <20240209200429.GA665650@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox