public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: Tom Lane <[email protected]>
Cc: Pavlo Golub <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role
Date: Wed, 14 Feb 2024 12:49:56 -0600
Message-ID: <20240214184956.GA372883@nathanxps13> (raw)
In-Reply-To: <[email protected]>
References: <CAK7ymcLmEYWyQkiCZ64WC-HCzXAB0omM=Ypj9B3rXe8vUAFMqw@mail.gmail.com>
	<20240209163657.GC663211@nathanxps13>
	<[email protected]>
	<20240212154945.GA1645880@nathanxps13>
	<20240213212928.GA262402@nathanxps13>
	<[email protected]>
	<[email protected]>

On Wed, Feb 14, 2024 at 01:45:31PM -0500, Tom Lane wrote:
> "Pavlo Golub" <[email protected]> writes:
>> Oh, thanks! I forgot, indeed, to update docs and catalog version! My 
>> bad!
> 
> Docs, yes, but don't include catversion bumps in submitted patches.
> They'll just lead to merge problems when somebody else changes the
> current catversion.  We rely on the committer to remember to do this
> (which is an imperfect system, but...)

+1, I only included it in the patch I posted so that I didn't forget it...

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role
  In-Reply-To: <20240214184956.GA372883@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox