pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: jian he <jian.universality@gmail.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Nikita Malakhov <hukutoc@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg_column_toast_chunk_id: a function to get a chunk ID of a TOASTed value
Date: Thu, 7 Mar 2024 16:56:17 -0600
Message-ID: <20240307225617.GA615950@nathanxps13> (raw)
In-Reply-To: <20240205162823.6c705517ca6898e482b69b9e@sraoss.co.jp>
References: <CACJufxEUcJGsxVmGtdQ+N1SOs7mbZajmNmZHrScWi8ZAm5VnuA@mail.gmail.com>
	<20240126094237.cec181d85e05556533d79914@sraoss.co.jp>
	<CACJufxH9NPo=N_Sg2fdegu_d0+hLQ-wUBibwcBjtHCp40qCPow@mail.gmail.com>
	<20240130133459.b1748c23998201476f49ca59@sraoss.co.jp>
	<CACJufxEmN=CPZt9-ZFLF7fje_-6kv51jV08w8p0e89O1Mg8RfA@mail.gmail.com>
	<20240130145632.d6609830bfd5139115f302cf@sraoss.co.jp>
	<CACJufxGpqVg9j_Fb7aBRwricx1ZTV+vEQfUmwuVpNhrRyvcAdA@mail.gmail.com>
	<20240201134524.d647b3d185e5252162eb0436@sraoss.co.jp>
	<CACJufxHyDKcB+34JUDFJubO7GkLNNjZXxbf9jSnSdqVKS8T9+g@mail.gmail.com>
	<20240205162823.6c705517ca6898e482b69b9e@sraoss.co.jp>

On Mon, Feb 05, 2024 at 04:28:23PM +0900, Yugo NAGATA wrote:
> On Thu, 1 Feb 2024 17:59:56 +0800
> jian he <jian.universality@gmail.com> wrote:
>> v6 patch looks good.
> 
> Thank you for your review and updating the status to RwC!

I think this one needs a (pretty trivial) rebase.  I spent a few minutes
testing it out and looking at the code, and it seems generally reasonable
to me.  Do you think it's worth adding something like a
pg_column_toast_num_chunks() function that returns the number of chunks for
the TOASTed value, too?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (26+ messages)  latest in thread

Message-ID: <20240307225617.GA615950@nathanxps13>
Permalink:  ../20240307225617.GA615950@nathanxps13/
Also on:    postgresql.org/message-id/20240307225617.GA615950@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, nagata@sraoss.co.jp, jian.universality@gmail.com, sk@zsrv.org, hukutoc@gmail.com
  Subject: Re: pg_column_toast_chunk_id: a function to get a chunk ID of a TOASTed value
  In-Reply-To: <20240307225617.GA615950@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox