From: Nathan Bossart <nathandbossart@gmail.com>
To: Imseih (AWS), Sami <simseih@amazon.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: allow changing autovacuum_max_workers without restarting
Date: Fri, 12 Apr 2024 13:40:00 -0500
Message-ID: <20240412184000.GA2416270@nathanxps13> (raw)
In-Reply-To: <DC833F51-881A-47F9-AEF6-B2E1DE46CDC8@amazon.com>
References: <20240410212344.GA1824549@nathanxps13>
<D04DFE2E-290F-43BA-9368-952F2B85E0C2@amazon.com>
<20240411144240.GD1882158@nathanxps13>
<66B70E79-54C0-4E58-831D-502B4B97E33D@amazon.com>
<20240411192423.GB2005410@nathanxps13>
<DC833F51-881A-47F9-AEF6-B2E1DE46CDC8@amazon.com>
On Fri, Apr 12, 2024 at 05:27:40PM +0000, Imseih (AWS), Sami wrote:
> A few comments on the POC patch:
Thanks for reviewing.
> 1/ We should emit a log when autovacuum_workers is set higher than the max.
Hm. Maybe the autovacuum launcher could do that.
> 2/ should the name of the restart limit be "reserved_autovacuum_workers"?
That's kind-of what I had in mind, although I think we might want to avoid
the word "reserved" because it sounds a bit like reserved_connections and
superuser_reserved_connections. "autovacuum_max_slots" or
"autovacuum_max_worker_slots" might be worth considering, too.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, simseih@amazon.com
Subject: Re: allow changing autovacuum_max_workers without restarting
In-Reply-To: <20240412184000.GA2416270@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox