From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Shlok Kyal <shlok.kyal.oss@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: kuroda.hayato@fujitsu.com <kuroda.hayato@fujitsu.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: FabrÃzio de Royes Mello <fabriziomello@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Subject: Re: speed up a logical replica setup
Date: Sun, 30 Jun 2024 12:25:34 -0700
Message-ID: <20240630192534.11.nmisch@google.com> (raw)
In-Reply-To: <2509767.1719773880@sss.pgh.pa.us>
References: <CAA4eK1KdCb+5sjYu6qCMXXdCX1y_ihr8kFzMozq0=P=auYxgog@mail.gmail.com>
<CANhcyEV6q1Vhd37i1axUeScLi0UAGVxta1LDa0BV0Eh--TcPMg@mail.gmail.com>
<CAA4eK1JaQcAZ=n513-4VDW4ujE9T9f007fczNCpVDbg1smhT4g@mail.gmail.com>
<5da4b286-e570-4341-8262-92d763f6b1a4@app.fastmail.com>
<776c5cac-5ef5-4001-b1bc-5b698bc0c62a@app.fastmail.com>
<3c024250-3f13-4f4d-b8e9-55f176db4abf@eisentraut.org>
<0dffca12-bf17-4a7a-334d-225569de5e6e@gmail.com>
<2377319.1719766794@sss.pgh.pa.us>
<2507765.1719772840@sss.pgh.pa.us>
<2509767.1719773880@sss.pgh.pa.us>
On Sun, Jun 30, 2024 at 02:58:00PM -0400, Tom Lane wrote:
> I wrote:
> > In hopes of moving things along as we approach the v18 branch,
> > I went ahead and pushed Kuroda-san's patches (with a bit of
> > further editorialization).
>
> So b3f5ccebd promptly blew up on fairywren [1]:
>
> connection error: 'psql: error: unterminated quoted string in connection info string'
> while running 'psql -XAtq -d port=52984 host=C:/tools/nmsys64/tmp/hHg_pngw4z dbname='regression\\\\"\\\\ !"#$%&\\'()*+,-\\\\\\\\"\\\\\\\\\\\\' -f - -v ON_ERROR_STOP=1' at C:/tools/nmsys64/home/pgrunner/bf/root/HEAD/pgsql/src/test/perl/PostgreSQL/Test/Cluster.pm line 2124.
>
> This shows that the command-line arguments to psql are not getting
> adequately quoted on that platform. AFAICS, we are relying on
> IPC::Run::run to perform such quoting, and it seems to be
> falling down here. I wonder what version of IPC::Run fairywren
> is using.
It does look consistent with IPC::Run predating v20220807.0, hence lacking the
https://github.com/toddr/IPC-Run/issues/142 fix. I wondered how this animal
was passing 002_pg_upgrade.pl, but it seems the animal has run TAP suites only
occasionally. Passes in the last week were TAP-free.
> [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2024-06-30%2018%3A03%3A06
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, andrew@dunslane.net, peter@eisentraut.org, exclusion@gmail.com, euler@eulerto.com, amit.kapila16@gmail.com, shlok.kyal.oss@gmail.com, tomas.vondra@enterprisedb.com, kuroda.hayato@fujitsu.com, bharath.rupireddyforpostgres@gmail.com, pgsql-hackers@lists.postgresql.org, michael@paquier.xyz, andres@anarazel.de, ashutosh.bapat.oss@gmail.com, fabriziomello@gmail.com, vignesh21@gmail.com
Subject: Re: speed up a logical replica setup
In-Reply-To: <20240630192534.11.nmisch@google.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox