From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tender Wang <tndrwang@gmail.com>
Cc: Junwang Zhao <zhjwpku@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Baehler Thomas SBB CFF FFS <thomas.baehler2@sbb.ch>
Cc: Guillaume Lelarge <guillaume@lelarge.info>
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails
Date: Tue, 20 Aug 2024 10:26:51 +0200
Message-ID: <20240820102651.273ecdf5@karst> (raw)
In-Reply-To: <202408072250.2c4fkhwf56lk@alvherre.pgsql>
References: <CAHewXN=ZZ8Jep1kbSUdRXfgyF3V2tgYUGXh04C95uDSuD0rJgg@mail.gmail.com>
<202408072250.2c4fkhwf56lk@alvherre.pgsql>
On Wed, 7 Aug 2024 18:50:10 -0400
Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> On 2024-Jul-26, Tender Wang wrote:
>
> > Junwang Zhao <zhjwpku@gmail.com> 于2024年7月26日周五 14:57写道：
> >
> > > There is a bug report[0] Tender comments might be the same issue as
> > > this one, but I tried Alvaro's and mine patch, neither could solve
> > > that problem, I did not tried Tender's earlier patch thought. I post
> > > the test script below in case you are interested.
> >
> > My earlier patch should handle Alexander reported case. But I did not
> > do more test. I'm not sure that wether or not has dismatching between
> > pg_constraint and pg_trigger.
> >
> > I aggred with Alvaro said that "requires a much more invasive
> > solution".
>
> Here's the patch which, as far as I can tell, fixes all the reported
> problems (other than the one in bug 18541, for which I proposed an
> unrelated fix in that thread[1]). If you can double-check, I would very
> much appreciate that. Also, I think the test cases the patch adds
> reflect the provided examples sufficiently, but if we're still failing
> to cover some, please let me know.
I'm back on this issue as well. I start poking at this patch to review it,
test it, challenge it and then report here.
I'll try to check if some other issues might have lost/forgot on they way as
well.
In the meantime, thank you Alvaro, Tender and Junwang for your work, time,
research and patches!
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jgdr@dalibo.com, alvherre@alvh.no-ip.org, tndrwang@gmail.com, zhjwpku@gmail.com, exclusion@gmail.com, thomas.baehler2@sbb.ch, guillaume@lelarge.info
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails
In-Reply-To: <20240820102651.273ecdf5@karst>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox