From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Andrew Borodin <amborodin86@gmail.com>
Cc: i.lazarev@postgrespro.ru, Yura Sokolov <y.sokolov@postgrespro.ru>
Cc: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Gilles Darold <gilles@darold.net>
Cc: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers mailing list <pgsql-hackers@postgresql.org>
Subject: Re: MultiXact\SLRU buffers configuration
Date: Tue, 20 Aug 2024 20:13:12 -0400
Message-ID: <202408210013.knpjya6p656v@alvherre.pgsql> (raw)
In-Reply-To: <ZsUnJUlSOBNAzwW1@paquier.xyz>
On 2024-Aug-21, Michael Paquier wrote:
> I see that you've gone the way with the SQL function doing a load().
> Would it be worth switching the test to rely on the two macros for
> load and caching instead? I've mentioned that previously but never
> got down to present a patch for the sake of this test.
Hmm, I have no opinion on which way is best. You probably have a better
sense of what's better for the injections point interface, so I'm happy
to defer to you on this.
> + /* reset in case this is a restart within the postmaster */
> + inj_state = NULL;
I'm not sure that this assignment actually accomplishes anything ...
I don't understand what do the inj_stats_enabled stuff have to do with
this patch. I suspect it's a git operation error, ie., you seem to have
squashed two different things together.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Industry suffers from the managerial dogma that for the sake of stability
and continuity, the company should be independent of the competence of
individual employees." (E. Dijkstra)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, michael@paquier.xyz, x4mmm@yandex-team.ru, vignesh21@gmail.com, amborodin86@gmail.com, y.sokolov@postgrespro.ru, andres@anarazel.de, thomas.munro@gmail.com, gilles@darold.net, aekorotkov@gmail.com, a.lubennikova@postgrespro.ru, daniel@yesql.se, horikyota.ntt@gmail.com
Subject: Re: MultiXact\SLRU buffers configuration
In-Reply-To: <202408210013.knpjya6p656v@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox