pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tatsuo Ishii <ishii@postgresql.org>
To: orlovmg@gmail.com
Cc: dgrowleyml@gmail.com
Cc: ashutosh.bapat.oss@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
Date: Wed, 04 Sep 2024 09:06:57 +0900 (JST)
Message-ID: <20240904.090657.995734319001610943.ishii@postgresql.org> (raw)
In-Reply-To: <CACG=ezZkhtCzeCkDY=WVYwvsNt0XffRZ7a7x6yH=D14cW=Eo8w@mail.gmail.com>
References: <20240709.154409.1091516017393224028.ishii@postgresql.org>
	<20240710.183610.1211398886785110571.ishii@postgresql.org>
	<CACG=ezZkhtCzeCkDY=WVYwvsNt0XffRZ7a7x6yH=D14cW=Eo8w@mail.gmail.com>

> Hi!
> 
> +1 for the idea of the patch. Consider it useful.
> 
> I looked at the patch set and don't see any obvious defects. It applies
> without any problems and looks pretty good for me.

Thank you for reviewing my patch.

> Only one thing is left to do. Add basic tests for the added functionality
> to make it committable.  For example, as in the
> mentioned 1eff8279d494b9.

Agreed. Probably add to explain.sql?

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp





view thread (53+ messages)  latest in thread

Message-ID: <20240904.090657.995734319001610943.ishii@postgresql.org>
Permalink:  ../20240904.090657.995734319001610943.ishii@postgresql.org/
Also on:    postgresql.org/message-id/20240904.090657.995734319001610943.ishii@postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ishii@postgresql.org, orlovmg@gmail.com, dgrowleyml@gmail.com, ashutosh.bapat.oss@gmail.com
  Subject: Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
  In-Reply-To: <20240904.090657.995734319001610943.ishii@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox