From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Bruce Momjian <bruce@momjian.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Corey Huinker <corey.huinker@gmail.com>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: jian he <jian.universality@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Statistics Import and Export
Date: Wed, 27 Nov 2024 16:57:35 +0100
Message-ID: <202411271557.gaewckwu64dm@alvherre.pgsql> (raw)
In-Reply-To: <Z0c_INg71CC_QmU5@momjian.us>
On 2024-Nov-27, Bruce Momjian wrote:
> On Wed, Nov 27, 2024 at 09:18:45AM -0600, Nathan Bossart wrote:
> > > Maybe not remove the option, but add a required parameter:
> > > --analyze-in-stages=all / missing
> > >
> > > That way, if the option is missing, the user can adapt the command line
> > > according to need.
> >
> > I like this idea.
>
> Would there be a default?
There would be no default. Running with no option given would raise an
error. The point is: you want to break scripts currently running
--analyze-in-stages so that they can make a choice of which of these two
modes to run. Your proposal (as I understand it) is to remove the
--analyze-in-stages option and add two other options. My proposal is to
keep --analyze-in-stages, but require it to have a specifier of which
mode to run. Both achieve what you want, but I think mine achieves it
in a cleaner way.
> Uh, do we have parameters that require a boolean option like this?
I'm not sure what exactly are you asking here.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"La gente vulgar sólo piensa en pasar el tiempo;
el que tiene talento, en aprovecharlo"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, bruce@momjian.us, nathandbossart@gmail.com, magnus@hagander.net, corey.huinker@gmail.com, pgsql@j-davis.com, jian.universality@gmail.com, boekewurm+postgres@gmail.com, tgl@sss.pgh.pa.us, sfrost@snowman.net, ashutosh.bapat.oss@gmail.com, smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Statistics Import and Export
In-Reply-To: <202411271557.gaewckwu64dm@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox