public inbox for [email protected]
help / color / mirror / Atom feedFrom: Álvaro Herrera <[email protected]>
To: Melanie Plageman <[email protected]>
Cc: Sergey Tatarintsev <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: pgbench with partitioned tables
Date: Sat, 8 Feb 2025 11:32:58 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAKRu_bq3z7oQ4SQRh1EOMFque1xDDO_UdDub+d0XiE4rpGrtw@mail.gmail.com>
On 2025-Feb-07, Melanie Plageman wrote:
> Okay, I've stared at this a bit, and it seems basically fine the way
> it is (I might add a bit more whitespace, clean up the commit message,
> etc). So I'm interested in committing it. I will admit that having
> never committed anything to pgbench, I'm a bit nervous. So, give me a
> couple days to work up the nerve.
Sounds good. I only wanted to say that I would use PQexecParams()
instead of PQexec() in the new function, avoiding the psprintf and
pfree, and also that initializing relkind to RELKIND_RELATION is strange
and probably unnecessary.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Cuando mañana llegue pelearemos segun lo que mañana exija" (Mowgli)
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgbench with partitioned tables
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox