pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Sutou Kouhei <kou@clear-code.com>
To: sawada.mshk@gmail.com
Cc: michael@paquier.xyz
Cc: zhjwpku@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: Make COPY format extendable: Extract COPY TO format implementations
Date: Wed, 26 Feb 2025 11:08:26 +0900 (JST)
Message-ID: <20250226.110826.297987517588158968.kou@clear-code.com> (raw)
In-Reply-To: <CAD21AoB3TiyuCcu02itGktUE6L4YGqwWT_LRtYrFkW7xedoe+g@mail.gmail.com>
References: <CAD21AoBjzkL2Lv7j4teaHBZvNmKctQtH6X71kN_sj6Fm-+VvJQ@mail.gmail.com>
	<20250226.085159.1492932557196528740.kou@clear-code.com>
	<CAD21AoB3TiyuCcu02itGktUE6L4YGqwWT_LRtYrFkW7xedoe+g@mail.gmail.com>

Hi,

In <CAD21AoB3TiyuCcu02itGktUE6L4YGqwWT_LRtYrFkW7xedoe+g@mail.gmail.com>
  "Re: Make COPY format extendable: Extract COPY TO format implementations" on Tue, 25 Feb 2025 17:14:43 -0800,
  Masahiko Sawada <sawada.mshk@gmail.com> wrote:

> I've attached updated patches.

Thanks.

I found one more missing last ".":

0002:

> --- a/src/backend/commands/copyfrom.c
> +++ b/src/backend/commands/copyfrom.c

> @@ -106,6 +106,145 @@ typedef struct CopyMultiInsertInfo

> +/*
> + * Built-in format-specific routines. One-row callbacks are defined in
> + * copyfromparse.c
> + */

copyfromparse.c -> copyfromparse.c.


Could you push them?


Thanks,
-- 
kou





view thread (340+ messages)  latest in thread

Message-ID: <20250226.110826.297987517588158968.kou@clear-code.com>
Permalink:  ../20250226.110826.297987517588158968.kou@clear-code.com/
Also on:    postgresql.org/message-id/20250226.110826.297987517588158968.kou@clear-code.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: kou@clear-code.com, sawada.mshk@gmail.com, michael@paquier.xyz, zhjwpku@gmail.com
  Subject: Re: Make COPY format extendable: Extract COPY TO format implementations
  In-Reply-To: <20250226.110826.297987517588158968.kou@clear-code.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox