From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: jian he <jian.universality@gmail.com>
Cc: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Cc: Robert Treat <rob@xzilla.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN
Date: Mon, 24 Mar 2025 11:37:20 +0100
Message-ID: <202503241037.pjpyt5j7xrfs@alvherre.pgsql> (raw)
In-Reply-To: <CACJufxGLcbFVS8xAC9OBPn0U_2YjKOiHLdmBrtds1j=5eA5MMA@mail.gmail.com>
On 2025-Mar-24, jian he wrote:
> In the current development branch,
> virtual generated columns still do not support the domain.
> you can not change the generation expression if it contains a check
> constraint on it.
> so virtual generated columns don't need rewriting.
>
> IMHO, the committed doc description didn't mention this exception.
> we need some text to cover this exception?
I'd add a note about these two things to the open items page, and wait
to see if we get some of these limitations fixed, so that if we don't,
we remember to note this limitation in the documentation.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"All rings of power are equal,
But some rings of power are more equal than others."
(George Orwell's The Lord of the Rings)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, jian.universality@gmail.com, ikedamsh@oss.nttdata.com, rob@xzilla.net, pgsql-hackers@lists.postgresql.org
Subject: Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN
In-Reply-To: <202503241037.pjpyt5j7xrfs@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox