From: Álvaro Herrera <alvherre@kurilemu.de>
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_dump does not dump domain not-null constraint's comments
Date: Wed, 7 May 2025 16:56:01 +0200
Message-ID: <202505071456.elpjza2ky65d@alvherre.pgsql> (raw)
In-Reply-To: <CACJufxEkn5s6-8H_Jao0ChtMo_mhOqkxXMAZmLyW6zPgtMp6Fg@mail.gmail.com>
Ooh, you know what? I ran your the CREATE DOMAIN statement in your new
test and pg_dump'ed that, and as far as I can tell the _name_ of the
not-null constraint is not dumped either. So it's not just the comment
that we're losing. That's a separate bug, and probably needs to be
fixed first, although I'm not sure if that one is going to be
back-patchable. Which means, I withdraw my earlier assessment that the
comment fix is back-patchable as a whole.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, jian.universality@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_dump does not dump domain not-null constraint's comments
In-Reply-To: <202505071456.elpjza2ky65d@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox