From: Álvaro Herrera <alvherre@kurilemu.de>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump --with-* options
Date: Wed, 30 Jul 2025 22:04:14 +0200
Message-ID: <202507302004.bjwvd3jk6rh6@alvherre.pgsql> (raw)
In-Reply-To: <cf21ea99caa39e89d26b8d83d78610db8938bdba.camel@j-davis.com>
On 2025-Jul-30, Jeff Davis wrote:
> On Wed, 2025-07-30 at 10:23 +0200, Álvaro Herrera wrote:
> > Maybe we should invent a new
> > switch, something like
> > --include=[schema,data,statistics]
> > with which users can give one or more comma-separated types to be
> > included in the dump.
>
> Robert Treat brought up a similar idea before:
>
> https://www.postgresql.org/message-id/CABV9wwO5v8Nu8q%2BxWexMdL3Z%2B2xS%3DfFJMQetBSHy3tR64wNHOA%40ma...
Oh, I hadn't seen it, but now that I do, it seems identical to mine. He
even used some of the same terms I did.
> > Then we state that --data-only is synonym for --include=data and
> > --schema-only is synonym for --include=schema, and we don't need any
> > other switches. Then it is obvious what happens, how to combine
> > object types in the dumps and restores, and there's no need to reject
> > invalid combinations because there aren't any.
>
> I assume that should be read as something like "include only", because
> --include=data would also be excluding the schema and the stats.
Of course.
> And if that's the case, it does seem strange to do something like "--
> include=data --schema-only".
> Another question: could you have multiple --include options, like "--
> include=data --include=schema"? Because you currently can't do "--data-
> only --schema-only". So that would make it not quite an alias.
IMO we should only allow one --include.
> If we go in this direction, it might be easier to just say that --
> include conflicts with --schema-only and --data-only.
Yep.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Small aircraft do not crash frequently ... usually only once!"
(ponder, http://thedailywtf.com/)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, pgsql@j-davis.com, masao.fujii@oss.nttdata.com, robertmhaas@gmail.com, nathandbossart@gmail.com, peter@eisentraut.org
Subject: Re: pg_dump --with-* options
In-Reply-To: <202507302004.bjwvd3jk6rh6@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox