agora inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed

From: Álvaro Herrera <alvherre@kurilemu.de>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_createsubscriber --dry-run logging concerns
Date: Sat, 4 Oct 2025 13:57:44 +0200
Message-ID: <202510041156.qwirsemadsvd@alvherre.pgsql> (raw)
In-Reply-To: <CAHut+Ps9B3ZzLRGkDZxCPuT4=Pb9G+G3HpWz7SKD-b02dmr9Yg@mail.gmail.com>

On 2025-Oct-03, Peter Smith wrote:

> Summary
> 
> The idea to change the pg_log_info macro globally seems risky. There
> are 400+ usages of this in the PG code, way beyond the scope of these
> few tools that have a dry-run.

Ok.

> So, that makes pg_createsubscriber the odd man out. Instead of
> introducing a new logging macro, perhaps it's better (for code
> consistency) just to change pg_createsubscriber to use that same
> logging pattern.

Sure, let's go that way.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/

view thread (27+ messages)  latest in thread

Message-ID: <202510041156.qwirsemadsvd@alvherre.pgsql>
Permalink:  ../202510041156.qwirsemadsvd@alvherre.pgsql/
Also on:    postgresql.org/message-id/202510041156.qwirsemadsvd@alvherre.pgsql

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@kurilemu.de, smithpb2250@gmail.com, kuroda.hayato@fujitsu.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_createsubscriber --dry-run logging concerns
  In-Reply-To: <202510041156.qwirsemadsvd@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox