pg.ddx.io pgsql-hackers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Quan Zongliang <quanzongliang@yeah.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
Date: Fri, 31 Oct 2025 13:19:50 +0100
Message-ID: <202510311047.5wm5fp2t23we@alvherre.pgsql> (raw)
In-Reply-To: <aQQ7relrpdo6Pxyz@ip-10-97-1-34.eu-west-3.compute.internal>
On 2025-Oct-31, Bertrand Drouvot wrote:
> After giving it more thought, I'm inclined to postpone the compiler warning
> until XLogRecPtrIsValid() has been available for some time. The question is for
> how long?
Maybe we can mark it so that it becomes obsolete in a future version,
#if PG_VERSION_NUM >= 210000
[[obsolete]]
#endif
XLogRecPtrIsInvalid( .. )
so that people using it today won't get any noise, but once they do get
the warning, the versions without the other macro are already out of
support, so they can switch to the new one easily. (This presupposes
that we'd add the new macro to older branches as well, which shouldn't
be a problem.) Only extensions wishing to support PG versions older
than we support would have to work slightly harder, but that should be OK.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"I dream about dreams about dreams", sang the nightingale
under the pale moon (Sandman)
view thread (49+ messages) latest in thread
Message-ID: <202510311047.5wm5fp2t23we@alvherre.pgsql> Permalink: ../202510311047.5wm5fp2t23we@alvherre.pgsql/ Also on: postgresql.org/message-id/202510311047.5wm5fp2t23we@alvherre.pgsql ·
reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Reply to all the recipients using the --to and --cc options: reply via email To: pgsql-hackers@postgresql.org Cc: alvherre@kurilemu.de, bertranddrouvot.pg@gmail.com, peter@eisentraut.org, michael@paquier.xyz, hlinnaka@iki.fi, quanzongliang@yeah.net, pgsql-hackers@lists.postgresql.org Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro In-Reply-To: <202510311047.5wm5fp2t23we@alvherre.pgsql> * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox