From: Álvaro Herrera <alvherre@kurilemu.de>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Quan Zongliang <quanzongliang@yeah.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
Date: Thu, 6 Nov 2025 20:48:11 +0100
Message-ID: <202511061936.ivzq6rvsny27@alvherre.pgsql> (raw)
In-Reply-To: <aQywOKctVLwjDuuT@ip-10-97-1-34.eu-west-3.compute.internal>
On 2025-Nov-06, Bertrand Drouvot wrote:
> I see, I would have introduced XLogRecPtrIsInvalid() on the back branches only
> if there is a need to (a bugfix that would make use of it). But yeah, I agree
> that would add extra "unnecessary" work, so done as you suggested in the
> attached. I checked that 0001 apply on the [14-18]_STABLE branches successfully.
Okay, thanks, I have applied that one to all stable branches, except I
didn't add the judgemental comment about XLogRecPtrIsInvalid().
I also pushed 0002+0004+0005 together as one commit, so now we have
XLogRecPtrIsValid() everywhere.
I did a couple of minor transformations, where the new code would end
doing "!XLogRecPtrIsValid(x) ? A : B" it seems clearer to remove the
negation and invert the other two arguments in the ternary. We also had
this assertion,
- Assert(XLogRecPtrIsInvalid(state->istartpoint) == (state->istarttli == 0));
which was being transformed to have a negation. I chose to negate the
other side of the equality instead, that is,
+ Assert(XLogRecPtrIsValid(state->istartpoint) == (state->istarttli != 0));
which also seems clearer.
Now only 0003 remains ... I would change the complaining version to 21
there, because why not?
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Maybe there's lots of data loss but the records of data loss are also lost.
(Lincoln Yeoh)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, bertranddrouvot.pg@gmail.com, peter@eisentraut.org, michael@paquier.xyz, hlinnaka@iki.fi, quanzongliang@yeah.net, pgsql-hackers@lists.postgresql.org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
In-Reply-To: <202511061936.ivzq6rvsny27@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox