From: Álvaro Herrera <alvherre@kurilemu.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Quan Zongliang <quanzongliang@yeah.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
Date: Wed, 19 Nov 2025 17:49:42 +0100
Message-ID: <202511191638.v3iyak6r46t2@alvherre.pgsql> (raw)
In-Reply-To: <CA+TgmoZi28-mfUeaKOs6GvT69EDDngUSC521rcwGfhBXeqv3nw@mail.gmail.com>
On 2025-Nov-19, Robert Haas wrote:
> On Thu, Nov 6, 2025 at 2:48 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
> > Okay, thanks, I have applied that one to all stable branches, except
> > I didn't add the judgemental comment about XLogRecPtrIsInvalid().
>
> I'm rather late to the party here, but for what it's worth, I don't
> really think this was a good idea. Anyone who wants to write
> out-of-core code that works in the back-branches must still write it
> the old way, or it will potentially fail on older minor releases.
No, they don't need to. Thus far, they can still keep their code the
way it is. The next patch in the series (not yet committed, but I
intend to get it out at some point, unless there are objections) is
going to add an obsolescence warning when their code is compiled with
Postgres 21 -- by which time the minors without the new macro are going
to be two years old. Nobody needs to compile their code with minor
releases that old. So they can fix their code to work with Postgres 21
and with all contemporary minors. They don't need to ensure that their
code compiles with minors older than that.
We could make that Postgres 22, but I don't think that makes any
practical difference.
Maybe you misunderstood what the patch is doing.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, robertmhaas@gmail.com, bertranddrouvot.pg@gmail.com, peter@eisentraut.org, michael@paquier.xyz, hlinnaka@iki.fi, quanzongliang@yeah.net, pgsql-hackers@lists.postgresql.org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
In-Reply-To: <202511191638.v3iyak6r46t2@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox