From: Álvaro Herrera <alvherre@kurilemu.de>
To: Bryan Green <dbryan.green@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>
Cc: Jakub Wartak <jakub.wartak@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)
Date: Tue, 24 Feb 2026 18:08:04 +0100
Message-ID: <202602241705.pd2wr4oku4nh@alvherre.pgsql> (raw)
In-Reply-To: <0f76b00a-8d8d-4c6f-ba41-bf6ec5fb08e1@gmail.com>
On 2026-Feb-23, Bryan Green wrote:
> I have removed all but the SymCleanup form the backtrace_cleanup since
> it happens at process exit. I have implemented not retrying as you
> described above.
>
> Let me know if this was what you were thinking.
OK, thanks, that's pretty much what I was thinking. I've pushed this
now. One last change I did is add a check that the wchar2char() return
value isn't the full size of the output buffer, because IIUC that's the
way it's intended to be used, and it matches the one existing caller
that doesn't rely on the max_encoding_chars thing.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Entristecido, Wutra (canción de Las Barreras)
echa a Freyr a rodar
y a nosotros al mar"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, dbryan.green@gmail.com, euler@eulerto.com, jakub.wartak@enterprisedb.com, michael@paquier.xyz
Subject: Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)
In-Reply-To: <202602241705.pd2wr4oku4nh@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox